Merged
Conversation
The specification for the ETAG field is in https://datatracker.ietf.org/doc/html/rfc9110#name-etag. A valid entity tag must be surrounded by quotation marks. Furthermore, it doesn't make sense to send an entity tag that does not identify the ressource.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed change will send
"9.0.0CWmd-w-jCO5CZ4napfGmUm00"instead of9.0.0CWmd-w-jCO5CZ4napfGmUm00in the ETAG header. If there is a failure to generate an ETAG, the header is not send.The specification for the ETAG field is in https://datatracker.ietf.org/doc/html/rfc9110#name-etag. A valid entity tag must be surrounded by quotation marks. Furthermore, it doesn't make sense to send an entity tag that does not identify the ressource.
I have noticed the problem with the current entity tags generated by Kroki when I tried to set up caching and compression with HAProxy. HAProxy does not work as intended when the backend server sends invalid ETAG fields.