fix: add /title command support#16
Merged
zardoy merged 1 commit intozardoy:everythingfrom Mar 25, 2026
Merged
Conversation
Fixes zardoy#5 - Remove broken duplicate /title implementation from commands.ts - Fix pre-1.17 action codes in title.ts (action 3 for times, separate packets) - Add resetTitle function (action 5) distinct from clearTitle (action 4) - Fix clearTitle to use reset: false on new protocol - Differentiate clear vs reset behaviour in players.ts
Owner
|
You did t submit the pr on issuehunt btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Changes
/titleimplementation (broken regex, wrong packet calls)clearTitleto usereset: false, addresetTitlewith action 5clearvsresetactions, fixactionbarcase normalisationIssueHunt
Resolves bounty: https://oss.issuehunt.io/r/zardoy/space-squid/issues/5