feat(sign): support for sigstore bundle format#4369
Draft
brandtkeller wants to merge 18 commits intomainfrom
Draft
feat(sign): support for sigstore bundle format#4369brandtkeller wants to merge 18 commits intomainfrom
brandtkeller wants to merge 18 commits intomainfrom
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
brandtkeller
commented
Nov 15, 2025
| // Note: this is the backwards compatible behavior | ||
| // this will change in the future | ||
| // Legacy signature found | ||
| l.Warn("non-bundle format signature is being deprecated in favor of the sigstore bundle format") |
Member
Author
There was a problem hiding this comment.
Note the intent to deprecate the standard signature file at some point in the future. Allowing backwards compatibility while shifting all new package creations to using the bundle format.
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates Zarf package signing to the Sigstore bundle format, aligning with Cosign v3 standards and improving signature portability and verification capabilities.
Changes
The signing implementation now defaults to
NewBundleFormat: trueand generates both legacy signature files and the new bundle format (saved aszarf.bundle.sig). TheSignPackage()function automatically configures the bundle path through the BundlePath option, ensuring all signing operations produce both formats for backward compatibility.Verification logic implements a fallback strategy that prefers the bundle format over legacy signatures. When verifying packages, the system first checks for a bundle file, and if not found, falls back to the legacy signature format with a deprecation warning to inform users of the transition. Validation Package integrity checks now exclude bundle files from validation, treating them similarly to how legacy signature files are handled to prevent false validation errors.
The implementation maintains dual format support by generating both bundle and legacy signatures during signing operations. This enables a graceful migration path where verification prefers the modern bundle format but seamlessly falls back to legacy signatures with appropriate warnings. The bundle format is now enabled by default, aligning Zarf with Cosign v3 standards.
The bundle format significantly improves verification capabilities by including timestamps and transparency log entries, which enables verification of packages signed with short-lived certificates even after expiration. Existing packages with legacy signatures remain fully functional while new signatures automatically use the modern format. This sets the foundation for eventually deprecating legacy signature support.
Related Issue
Fixes #4296
Fixes #4276
Checklist before merging