Compare discriminants when checking modes/permissions#200
Open
josevalim wants to merge 1 commit intozed-industries:mainfrom
Open
Compare discriminants when checking modes/permissions#200josevalim wants to merge 1 commit intozed-industries:mainfrom
josevalim wants to merge 1 commit intozed-industries:mainfrom
Conversation
The APPROVAL_PRESETS have this shape:
preset id="read-only" approval=OnRequest sandbox=ReadOnly { access: FullAccess, network_access: false }
preset id="auto" approval=OnRequest sandbox=WorkspaceWrite { writable_roots: [], read_only_access: FullAccess, network_access: false, exclude_tmpdir_env_var: false, exclude_slash_tmp: false }
preset id="full-access" approval=Never sandbox=DangerFullAccess
However, the config permission sandbox, whenever a directory
is trusted, has this shape:
approval_policy=OnRequest
sandbox_policy=WorkspaceWrite { writable_roots: [AbsolutePathBuf("/Users/jose/.codex/memories")], read_only_access: FullAccess, network_access: false, exclude_tmpdir_env_var: false, exclude_slash_tmp: false }
As you can see, the WorkspaceWrite is not going to match,
because the struct has some information filled in. Therefore,
we only check the names themselves.
Closes zed-industries#194.
Contributor
Author
|
Btw, this happens based on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APPROVAL_PRESETS have this shape:
However, the config permission sandbox, whenever a directory is trusted, has this shape:
As you can see, the WorkspaceWrite is not going to match, because the struct has some information filled in. Therefore, we only check the names themselves.
Closes #194.