Update generated templates to match the current GPUI startup API#37
Open
andyhennie wants to merge 1 commit into
Open
Update generated templates to match the current GPUI startup API#37andyhennie wants to merge 1 commit into
andyhennie wants to merge 1 commit into
Conversation
Author
|
Would appreciate a review on whether this is the right place and shape for the fix. I hit this from a fresh scaffold locally and kept the patch as small as I could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this while trying a fresh scaffold locally.
The generated app still uses
Application::new().run(...), but current GPUI examples have moved togpui_platform::application(). With a newly generated project, the firstcargo runfails becauseApplication::newis no longer available.This updates the generated templates to use
gpui_platform::application()and adds the matching dependency in both the single-crate and workspace templates.What I verified locally:
cargo checkcargo checkRepro before this change:
cargo install create-gpui-app create-gpui-app --name my-app cd my-app cargo run