Skip to content

feat: support tls, quic, quic-v1#21

Merged
GrapeBaBa merged 1 commit intomainfrom
up
Oct 18, 2025
Merged

feat: support tls, quic, quic-v1#21
GrapeBaBa merged 1 commit intomainfrom
up

Conversation

@GrapeBaBa
Copy link
Member

No description provided.

Signed-off-by: Chen Kai <281165273grape@gmail.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @GrapeBaBa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Multiaddr implementation by integrating support for TLS, QUIC, and QUIC-V1 protocols. The changes involve updating the protocol definitions, modifying the internal logic for parsing and serializing multiaddrs, and adding comprehensive tests to ensure the new protocols are handled correctly. This allows the system to accurately represent and process network addresses that utilize these modern transport layers.

Highlights

  • TLS Protocol Support: Introduced support for the TLS protocol within the Multiaddr system, including a new constant, enum variant, and corresponding parsing and serialization logic.
  • QUIC and QUIC-V1 Protocol Support: Extended Multiaddr to explicitly support QUIC and QUIC-V1 protocols, ensuring they can be correctly represented and processed.
  • Multiaddr Parsing and Serialization: Updated the core Multiaddr parsing, encoding, and string conversion functions to properly handle the newly added TLS, QUIC, and QUIC-V1 protocols.
  • Test Coverage: Added new test cases to validate the correct functionality of Multiaddr with TLS, QUIC, and QUIC-V1, ensuring proper string conversion and parsing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for tls, quic, and quic-v1 protocols to the multiaddr implementation. The changes are consistently applied across encoding, decoding, and string representation functions, and include corresponding test cases. My review identifies one significant pre-existing issue in the string parsing logic that this PR builds upon. While the new protocol support is implemented correctly, the fromString function remains incomplete, failing to parse many other supported protocols. I've provided a high-severity comment detailing this issue and recommending it be addressed to ensure the library's correctness and reliability.

@GrapeBaBa GrapeBaBa merged commit d444e94 into main Oct 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant