feat: Convert types.is_* into TypeIs guards#215
Merged
Conversation
I've been using this for a little while, but makes more sense to live in the stubs https://github.com/narwhals-dev/narwhals/blob/16427440e6d74939c403083b52ce3fb0af7d63c7/narwhals/_arrow/utils.py#L44-L67
33 tasks
dangotbanned
changed the title
types._is_* into TypeIs guardstypes.is_* into TypeIs guards
dangotbanned
added a commit
to narwhals-dev/narwhals
that referenced
this pull request
Apr 30, 2025
We need **exactly one** type, but the new typing I added narrows it to **4** types zen-xu/pyarrow-stubs#215 ``` error: Value of type variable "_R" of function cannot be "Scalar[Int8Type | Int16Type | Int32Type | Int64Type] | Array[Any] | ChunkedArray[Any] | Scalar[Any]" [type-var] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this for a little while in
narwhals, but makes more sense to live in the stubshttps://github.com/narwhals-dev/narwhals/blob/16427440e6d74939c403083b52ce3fb0af7d63c7/narwhals/_arrow/utils.py#L44-L67