Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

We don't need call info method every time we want redis resource#100

Closed
alirezameskin wants to merge 1 commit intozendframework:developfrom
alirezameskin:develop
Closed

We don't need call info method every time we want redis resource#100
alirezameskin wants to merge 1 commit intozendframework:developfrom
alirezameskin:develop

Conversation

@alirezameskin
Copy link

No description provided.

@marc-mabe
Copy link
Member

@alireza-m Thank you for finding this!
But there is one possibility the version information would not get detected.
-> In case you add an existing and already connected redis resource to the resource manager - see https://github.com/alireza-m/zend-cache/blob/ede35a3dc6215decf88f23feaefac7438195e3cf/src/Storage/Adapter/RedisResourceManager.php#L337

The logic of this initialized flag is really strange on here and should be fixed.

@Moln
Copy link
Contributor

Moln commented Oct 28, 2016

But the $resource['version'] can be set only once.
See #119

@marc-mabe marc-mabe added this to the 2.7.2 milestone Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants