This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Give php the absolute use path to Traversable#134
Merged
weierophinney merged 1 commit intozendframework:masterfrom Apr 17, 2018
TysonAndre:patch-3
Merged
Give php the absolute use path to Traversable#134weierophinney merged 1 commit intozendframework:masterfrom TysonAndre:patch-3
use path to Traversable#134weierophinney merged 1 commit intozendframework:masterfrom
TysonAndre:patch-3
Conversation
Without that use statement, the check would always be false. See https://3v4l.org/#preview This was detected by etsy/phan, and the bug may or may not occur in real code. This change affects setFromArray() on line 315
geerteltink
approved these changes
Apr 30, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2018
Give php the absolute `use` path to Traversable
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2018
Member
|
Thanks, @TysonAndre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without that use statement, the check would always be false. See https://3v4l.org/#preview
This was detected by etsy/phan, and the bug may or may not occur in real code.
This change affects setFromArray() on line 315