cast to (int) for Curl adapter timeout config

[samsonasik]

same as what applied into Socket adapter

[Xerkus]

What is the reason for accepting non-integer timeout values?
I would say exception should be thrown instead.

[samsonasik]

just for consistent with socket adapter. if it should be get exception, the in socket adapter should get exception as well?

[Xerkus]

That would be my preference, yes. I will need to look into it sometime later, may be i don't see something.

[weierophinney]

I would prefer the following approach:

• Grab the config value.
• If it is not an integer or not a numeric string, throw an InvalidArgumentException.
• Cast to integer.

That approach ensures strings like timeout do not get cast to 0, which is obviously incorrect.

[samsonasik]

do we need to check $this->config['timeout'] and $this->config['connecttimeout'] in setOptions() function ? and change it at Socket adapter as well?

[samsonasik]

I've updated with integer and numeric check, applied to socket adapter as well.

[weierophinney]

Thanks, @samsonasik!