This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Method setCookies on Client accepts name=>value pairs or SetCookie instances#188
Merged
michalbundyra merged 2 commits intozendframework:masterfrom Nov 29, 2019
michalbundyra:hotfix/client-set-cookies
Merged
Method setCookies on Client accepts name=>value pairs or SetCookie instances#188michalbundyra merged 2 commits intozendframework:masterfrom michalbundyra:hotfix/client-set-cookies
michalbundyra merged 2 commits intozendframework:masterfrom
michalbundyra:hotfix/client-set-cookies
Conversation
…stances Per documentation it should be possible to pass array of SetCookie to Client::setCookies. Fixes #114
It can be only array as defined in method signature
froschdesign
approved these changes
Oct 15, 2019
michalbundyra
added a commit
that referenced
this pull request
Nov 29, 2019
Method setCookies on Client accepts name=>value pairs or SetCookie instances
michalbundyra
added a commit
that referenced
this pull request
Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per documentation it should be possible to pass array of SetCookie to Client::setCookies.
Fixes #114
See: https://docs.zendframework.com/zend-http/client/cookies/#usage
and method
getMatchingCookiesreturn array ofSetCookie.masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.