This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Protocol\AbstractProtocol: verbose errors#116
Merged
weierophinney merged 2 commits intozendframework:masterfrom Feb 14, 2017
Merged
Protocol\AbstractProtocol: verbose errors#116weierophinney merged 2 commits intozendframework:masterfrom
weierophinney merged 2 commits intozendframework:masterfrom
Conversation
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
Protocol\AbstractProtocol: verbose errors
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
Member
|
Thanks, @Slamdunk |
glensc
reviewed
Apr 3, 2017
| $this->socket = @stream_socket_client($remote, $errorNum, $errorStr, self::TIMEOUT_CONNECTION); | ||
| set_error_handler( | ||
| function ($error, $message = '') { | ||
| throw new Exception\RuntimeException(sprintf('Could not open socket: %s', $message), $error); |
Contributor
There was a problem hiding this comment.
isn't such code faulty that error handler is not restored when exception is thrown?
point being that throwing exception not necessarily terminate the program, it may resume working with this error handler being still set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently an update of openssl stopped our app (aright) becase one of our partner had messy servers:
But it took us a while to get the right error, because an anonym
Could not open socketwas the only message thrown by the smtp protocol.Also, many times
$errorNumand$errorStrare empty.With this PR the error-suppressing operator
@is deleted and a specific error handler to exception function handles the possible warnings.