Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

update phpunit dep for expectException#145

Closed
glensc wants to merge 1 commit intozendframework:masterfrom
eventum:patch-2
Closed

update phpunit dep for expectException#145
glensc wants to merge 1 commit intozendframework:masterfrom
eventum:patch-2

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented May 18, 2017

this should fix travis errors that every PR in this project is suffering.

PHP Fatal error:
Call to undefined method
ZendTest\Mail\Protocol\SmtpPluginManagerCompatibilityTest::expectException()
in /home/travis/build/zendframework/zend-mail/vendor/zendframework/zend-servicemanager/src/Test/CommonPluginManagerTrait.php on line 56

this is because SmtpPluginManagerCompatibilityTest uses trait from other project CommonPluginManagerTrait which uses expectException phpunit method.

specified phpunit dependency that has such method available

@glensc
Copy link
Contributor Author

glensc commented May 18, 2017

probably broken since #72 got merged by @weierophinney, could you please merge this to master

EDIT: replaced 9494b07 commit with e776ea5

@weierophinney
Copy link
Member

#132 updates the develop branch to PHPUnit 6, and does all of these changes already. Our next version will be 2.8.0, and incorporate those changes.

@glensc
Copy link
Contributor Author

glensc commented Jun 8, 2017

i hope you have look at all open PR's, i've submitted several ones. some are complete, some need feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants