This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Add identification headers#166
Merged
weierophinney merged 8 commits intozendframework:masterfrom Jun 6, 2018
Merged
Conversation
glensc
reviewed
Aug 12, 2017
src/Header/IdentificationField.php
Outdated
|
|
||
| private static function trimMessageId($id) | ||
| { | ||
| return trim($id, "\t\n\r\0\xOB<>"); |
Contributor
There was a problem hiding this comment.
what is \xOB ? you meant \x0B or just \v ?
glensc
reviewed
Aug 12, 2017
| <?php | ||
|
|
||
|
|
||
| namespace Zend\Mail\Header; |
Contributor
There was a problem hiding this comment.
i'm sure the copyright should be in every file
Member
|
@Xerkus can you review this please? |
- adds parameter annotations - uses `::class` notation, instead of string manipulation, to provide FQCN values
weierophinney
force-pushed
the
identification-headers
branch
from
28039ba to
b64742b
Compare
weierophinney
added a commit
that referenced
this pull request
Jun 6, 2018
weierophinney
added a commit
that referenced
this pull request
Jun 6, 2018
Member
|
Thanks, @mleko! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.