This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Add PHPDoc comments#171
Closed
danielabyan wants to merge 1 commit intozendframework:masterfrom
danielabyan:add-php-doc-comments
Closed
Add PHPDoc comments#171danielabyan wants to merge 1 commit intozendframework:masterfrom danielabyan:add-php-doc-comments
danielabyan wants to merge 1 commit intozendframework:masterfrom
danielabyan:add-php-doc-comments
Conversation
In some cases, the IDE can not recognize the types of variables. To solve this problem, I've added comments in some places. And I added comments for the following methods - Add missing comment for method GenericHeader::fromString - Add PHPDoc @return comment for Smtp::setUseCompleteQuit() method - PHPDoc @return comment does not apply to the constructor because remove this comment for Address::__construct - Add Mime\Message type for Mail\Message::$body property.
Ocramius
added a commit
that referenced
this pull request
Mar 1, 2018
Member
|
@danielabyan thanks! Manually merged to 0c37b59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the IDE can not recognize the types of variables. To solve this problem, I've added comments in some places.
And I added comments for the following methods