Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

added missing new keyword#180

Closed
uikolas wants to merge 1 commit intozendframework:masterfrom
uikolas:uikolas-missing-keyword
Closed

added missing new keyword#180
uikolas wants to merge 1 commit intozendframework:masterfrom
uikolas:uikolas-missing-keyword

Conversation

@uikolas
Copy link
Contributor

@uikolas uikolas commented Nov 10, 2017

As far I understand, these are not functions (maybe i'm not correct?), but classes, so added missing new keyword

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius added this to the 2.9.0 milestone Mar 1, 2018
@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2018

@uikolas thanks! Manually merged in 7fe57dc

@Ocramius Ocramius closed this Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants