Conversation
|
|
||
| $header = new GenericHeader($name, $value); | ||
| $res = $header->toString(); | ||
| $this->assertEquals($encoded, $res); |
There was a problem hiding this comment.
This last setup/assertion check is just a proxy for a call to zend-mime, that is affected by #183 (comment)
Is this really necessary?
There was a problem hiding this comment.
Without this check, build fails only on PHP 7.2 with lowest/locked dependencis because of old zend-validator.
Latest depencencies on PHP 7.2 are fine.
|
@froschdesign may I ask your review? |
|
Any ETA for merging this PR? |
|
zend-validator has already been updated. I think that it would be okay to change the required version of zend-validator in the composer.json file from ^2.6 to ^2.10. Then, the Travis could be run again and then the PR can be merged. |
|
Taking this over as soon as I have a second |
|
Verified locally - re-running travis since it failed due to environment misconfiguration. |
|
WTH, this package still has PHP 5.6 support? Off with its head! |
But maybe we can drop it for 2.9 release? /cc @weierophinney |
|
@webimpress that's what I'm currently preparing. |
|
Thanks @Slamdunk! |
…NTL_IDNA_VARIANT_2003 is deprecated` deprecation notices occur
6 participants
.travis.ymlZF standards (zend-session/.travis.yml picked)idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecatedFix #177, #183
Supersedes #181, #192