This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Properly encode content-disposition header#251
Open
fredden wants to merge 6 commits intozendframework:masterfrom
fredden:magento-issue-25076
Open
Properly encode content-disposition header#251fredden wants to merge 6 commits intozendframework:masterfrom fredden:magento-issue-25076
fredden wants to merge 6 commits intozendframework:masterfrom
fredden:magento-issue-25076
Conversation
7 tasks
Member
|
This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#2. |
Member
|
This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a narrative description of what you are trying to accomplish:
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Always use ASCII for the
content-dispositionheader. When using UTF-8 encoding, this results in a header being set asContent-Disposition: =?utf-8?Q?inline?=which is not interpreted properly by Thunderbird nor Microsoft Exchange / Outlook. This pull request forces encoding for this header to always be ASCII, so that the header readsContent-Disposition: inlineand is correctly interpreted by email clients.Fixes: magento/magento2#25076