Skip to content

m-profile: Support picolibc startup mechanism#5

Merged
wearyzen merged 1 commit intozephyrproject-rtos:mainfrom
keith-packard:picolibc
Aug 7, 2025
Merged

m-profile: Support picolibc startup mechanism#5
wearyzen merged 1 commit intozephyrproject-rtos:mainfrom
keith-packard:picolibc

Conversation

@keith-packard
Copy link
Copy Markdown

@keith-packard keith-packard commented Jul 11, 2025

We don't need to use __cmsis_start when using picolibc; we can call main directly.

@github-actions github-actions bot mentioned this pull request Jul 11, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2025 •
edited
Loading

Test Results

   264 files     264 suites   0s ⏱️
    56 tests     54 ✅     2 💤 0 ❌
14 292 runs  12 124 ✅ 2 168 💤 0 ❌

Results for commit 5eb9063.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot mentioned this pull request Jul 21, 2025
Closed
wearyzen
wearyzen reviewed Jul 23, 2025
View reviewed changes
tomi-font
tomi-font reviewed Jul 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this seems good to upstream let's create an upstream PR now? 🙃

@wearyzen
Copy link
Copy Markdown
Collaborator

wearyzen commented Aug 1, 2025

coming back to this, @keith-packard do you plan to upstream the change first?

@keith-packard
Copy link
Copy Markdown
Author

keith-packard commented Aug 1, 2025

coming back to this, @keith-packard do you plan to upstream the change first?

Hrm. A complete change would involve additional code and some way to test it all. Maybe just this partial fix which makes it possible to use with external support would be accepted though?

@keith-packard
Copy link
Copy Markdown
Author

keith-packard commented Aug 1, 2025

ARM-software#246

@tomi-font
Copy link
Copy Markdown
Collaborator

tomi-font commented Aug 4, 2025

ARM-software#246

Nice. I saw it's already merged. Let's git cherry-pick -x to have the commit hash? unless if @wearyzen wants to do it some other way

@wearyzen
Copy link
Copy Markdown
Collaborator

wearyzen commented Aug 4, 2025

ARM-software#246

Nice. I saw it's already merged. Let's git cherry-pick -x to have the commit hash? unless if @wearyzen wants to do it some other way

I am ok with git cherry-pick -x for now

@keith-packard
m-profile/gcc: Support picolibc startup mechanism (ARM-software#246)
5eb9063 
Use picolibc's _start function instead of providing our own.

Signed-off-by: Keith Packard <keithp@keithp.com>
(cherry picked from commit e902f86)
@wearyzen wearyzen merged commit 30a859f into zephyrproject-rtos:main Aug 7, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomi-font tomi-font tomi-font left review comments

@wearyzen wearyzen wearyzen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keith-packard @wearyzen @tomi-font