Skip to content

fix(cron): preserve active model for custom endpoint jobs#2660

Merged
theonlyhennygod merged 1 commit intomainfrom
issue-2589-cron-custom-model
Mar 3, 2026
Merged

fix(cron): preserve active model for custom endpoint jobs#2660
theonlyhennygod merged 1 commit intomainfrom
issue-2589-cron-custom-model

Conversation

@theonlyhennygod
Copy link
Copy Markdown
Collaborator

Summary

  • fix cron_add model argument injection so scheduled agent jobs inherit the active model when model is omitted
  • replace legacy gpt-4o-mini fallback only for custom: provider endpoints to preserve compatibility with self-hosted OpenAI-compatible stacks
  • keep explicit non-custom provider model overrides unchanged
  • clarify tool schema guidance that model should be omitted unless explicitly requested

Validation

  • cargo test --package zeroclaw --lib maybe_inject_cron_add_delivery
  • cargo test --package zeroclaw --lib cron_add

Closes #2589

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 3, 2026

Warning

Rate limit exceeded

@theonlyhennygod has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3141e9a and 3de3ede.

📒 Files selected for processing (2)
  • src/agent/loop_.rs
  • src/tools/cron_add.rs

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'tools', 'path_filters', 'review_instructions'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-2589-cron-custom-model

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

PR intake checks found warnings (non-blocking)

Fast safe checks found advisory issues. CI lint/test/build gates still enforce merge quality.

  • Missing required PR template sections: ## Validation Evidence (required), ## Security Impact (required), ## Privacy and Data Hygiene (required), ## Rollback Plan (required)
  • Incomplete required PR template fields: summary problem, summary why it matters, summary what changed, validation commands, security risk/mitigation, privacy status, rollback plan
  • Missing Linear issue key reference (RMN-<id>, CDV-<id>, or COM-<id>) in PR title/body (recommended for traceability, non-blocking).

Action items:

  1. Complete required PR template sections/fields.
  2. (Recommended) Link this PR to one active Linear issue key (RMN-xxx/CDV-xxx/COM-xxx) for traceability.
  3. Remove tabs, trailing whitespace, and merge conflict markers from added lines.
  4. Re-run local checks before pushing:
    • ./scripts/ci/rust_quality_gate.sh
    • ./scripts/ci/rust_strict_delta_gate.sh
    • ./scripts/ci/docs_quality_gate.sh

Detected Linear keys: none

Run logs: https://github.com/zeroclaw-labs/zeroclaw/actions/runs/22643296184

Detected blocking line issues (sample):

  • none

Detected advisory line issues (sample):

  • none

@github-actions github-actions bot added agent Auto scope: src/agent/** changed. tool Auto scope: src/tools/** changed. labels Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Thanks for contributing to ZeroClaw.

For faster review, please ensure:

  • PR template sections are fully completed
  • cargo fmt --all -- --check, cargo clippy --all-targets -- -D warnings, and cargo test are included
  • If automation/agents were used heavily, add brief workflow notes
  • Scope is focused (prefer one concern per PR)

See CONTRIBUTING.md and docs/pr-workflow.md for full collaboration rules.

@github-actions github-actions bot added size: S Auto size: 81-250 non-doc changed lines. risk: high Auto risk: security/runtime/gateway/tools/workflows. and removed agent Auto scope: src/agent/** changed. tool Auto scope: src/tools/** changed. labels Mar 3, 2026
@theonlyhennygod theonlyhennygod self-assigned this Mar 3, 2026
@github-actions github-actions bot added distinguished contributor Contributor with 50+ merged PRs. agent: loop Auto module: agent/loop changed. tool: cron_add Auto module: tool/cron_add changed. labels Mar 3, 2026
@theonlyhennygod theonlyhennygod merged commit 9eb0b2c into main Mar 3, 2026
24 of 27 checks passed
@theonlyhennygod theonlyhennygod deleted the issue-2589-cron-custom-model branch March 3, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent: loop Auto module: agent/loop changed. distinguished contributor Contributor with 50+ merged PRs. risk: high Auto risk: security/runtime/gateway/tools/workflows. size: S Auto size: 81-250 non-doc changed lines. tool: cron_add Auto module: tool/cron_add changed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: custom openai endpoint model

1 participant