fix(install): pass user-selected cargo features to build#4693
Closed
rareba wants to merge 1 commit intozeroclaw-labs:masterfrom
Closed
fix(install): pass user-selected cargo features to build#4693rareba wants to merge 1 commit intozeroclaw-labs:masterfrom
rareba wants to merge 1 commit intozeroclaw-labs:masterfrom
Conversation
Add support for the ZEROCLAW_CARGO_FEATURES environment variable so users can request additional cargo features (e.g. "channel-matrix") when building from source. The variable is appended to CARGO_FEATURE_FLAGS and applies to both `cargo build` and `cargo install` invocations. Closes zeroclaw-labs#4654 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rareba
requested review from
JordanTheJet,
SimianAstronaut7 and
theonlyhennygod
as code owners
20 tasks
Collaborator
Contributor
Author
|
Makes sense — #4663 with CLI flag support and deduplication is more complete. Happy to defer to that PR. Thanks! |
Collaborator
|
Hey — this PR currently has failing CI checks. Could you rebase against current |
Contributor
Author
|
Closing in favor of #4663 which has broader coverage including CLI flag support and deduplication. Recommending closure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZEROCLAW_CARGO_FEATURESenv var support toinstall.shZEROCLAW_CARGO_FEATURES="channel-matrix"), the features are passed tocargo build --release --locked --features channel-matrix--features(comma-appends)Usage
ZEROCLAW_CARGO_FEATURES="channel-matrix" ./install.shFiles changed
install.sh— env var documentation + feature flag merging logicTest plan
ZEROCLAW_CARGO_FEATURES="channel-matrix" ./install.shbuilds with Matrix support--featuresflagCloses #4654