Fix DefaultExpected::into_owned lifetime #952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the lifetime returned from
DefaultExpected::into_ownedto be generic.This follows the pattern of other
into_ownedmethods in the crate, likeRichPattern::into_ownedorRichReason::into_owned.The current implementation has a fixed
'staticlifetime return, which doesn't work for me because I have tokens with a non-static lifetime.My current workaround is to reimplement
into_owned, which is awkward because ofDefaultExpected's#[non_exhaustive]-ness: