Use include path from Vulkan-Headers target if present #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Vulkan-Headers is used by the application, we can use the include path from it even though other ways to discover the include paths fail. This simplifies the usage of volk via CPM and when using it directly; it does require the application to include Vulkan-Headers first, as there's no way to discover it otherwise.
|
Works for me 👍🏻 |
tksuoran
added a commit
to tksuoran/erhe
that referenced
this pull request
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Vulkan-Headers is used by the application, we can use the include path from it even though other ways to discover the include paths fail. This simplifies the usage of volk via CPM and when using it as part of a project that also uses Vulkan-Headers; it does require the application to include Vulkan-Headers first, as there's no way to discover it otherwise.
Fixes #270.