Skip to content

Comments

[trainer] feat: fix training loop#19

Merged
zhtmike merged 9 commits intoverl-omnifrom
vllm-omni-dev
Feb 6, 2026
Merged

[trainer] feat: fix training loop#19
zhtmike merged 9 commits intoverl-omnifrom
vllm-omni-dev

Conversation

@zhtmike
Copy link
Owner

@zhtmike zhtmike commented Feb 5, 2026

What does this PR do?

fix training loop

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@zhtmike zhtmike changed the title [trainer] feat: fix trainer [trainer] feat: fix training loop Feb 5, 2026
@zhtmike zhtmike marked this pull request as ready for review February 6, 2026 04:47
@zhtmike zhtmike merged commit 8edd6d5 into verl-omni Feb 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants