Skip to content

Store partial images when the OTA image's size is unknown #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puddly merged 1 commit into from
Apr 26, 2023
Merged

Store partial images when the OTA image's size is unknown #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions zigpy_cli/ota.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,18 @@ def reconstruct_from_pcaps(

ota_chunks[image_key].add((offset, data))

unknown_sizes = set()

for key in ota_chunks:
if key in ota_sizes:
continue

unknown_sizes.add(key)
ota_sizes[key] = max(offset + len(data) for offset, data in ota_chunks[key])
LOGGER.error(
"Image size for %s not captured, assuming size %s", key, ota_sizes[key]
)

for image_key, image_size in ota_sizes.items():
image_version, image_type, image_manuf_code = image_key
print(
Expand Down Expand Up @@ -283,6 +295,7 @@ def reconstruct_from_pcaps(

filename = output_root / (
f"ota_t{image_type}_m{image_manuf_code}_v{image_version}"
f"{'_unk_size' if image_key in unknown_sizes else ''}"
f"{'_partial' if missing_ranges else ''}.ota"
)

Expand Down