Skip to content

feat: Exiva Restrictions#650

Merged
jprzimba merged 2 commits intomainfrom
exiva-restrictions
Mar 23, 2026
Merged

feat: Exiva Restrictions#650
jprzimba merged 2 commits intomainfrom
exiva-restrictions

Conversation

@jprzimba
Copy link
Copy Markdown
Collaborator

@jprzimba jprzimba commented Mar 19, 2026

jprzimba and others added 2 commits March 19, 2026 09:11
More details from opentibiabr/canary#3871

Co-Authored-By: Pedro Cruz <pedro.ha.cruz2022@gmail.com>
Co-Authored-By: Felipe <87909998+felipepaluco@users.noreply.github.com>
@jprzimba jprzimba merged commit 30a777b into main Mar 23, 2026
3 checks passed
@jprzimba jprzimba deleted the exiva-restrictions branch March 23, 2026 11:03
@leonardorifeli
Copy link
Copy Markdown

I found the issue affecting the debug build.

Build:
https://github.com/zimbadev/crystalserver/actions/runs/23535927626/job/68510970656
https://github.com/zimbadev/crystalserver/actions/runs/23294248330/job/67737358988

These two files use KV-related types directly:

src/io/functions/iologindata_load_player.cpp
src/io/functions/iologindata_save_player.cpp

They reference:

player->kv()->scoped(...)
ArrayType
IntType
ValueWrapper

But they do not include the KV headers that define those symbols.

This can lead to errors like:

invalid use of incomplete type 'KV'
'ArrayType' was not declared in this scope
'IntType' was not declared in this scope
'ValueWrapper' was not declared in this scope

Suggested fix: add these includes to both files:

#include "kv/kv.hpp"
#include "kv/kv_definitions.hpp"
#include "kv/value_wrapper.hpp"

It seems the release build may pass due to indirect includes, but the debug build exposes the missing direct dependencies.

If you want, I can prepare the fix and open a patch for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants