fix: add auth_methods client_secret_basic for refresh token and revok…#803
Conversation
|
cc @elinashoko |
|
heya @kufd thank you for your contribution, we'll review as soon as we can! |
muhlemmer
left a comment
There was a problem hiding this comment.
@kufd, can you plead amend the description of you PR and clearly state:
- What is the bug being solved. Preferably an issue with a reproducible case
- How is the bug solved
It's hard to understand the problem and the fix looking at the code alone.
|
@muhlemmer Could you please take a look at the PR description? |
|
@muhlemmer pls have a look |
|
@muhlemmer ping pls |
muhlemmer
left a comment
There was a problem hiding this comment.
Change looks good, thanks. One small formatting comment.
example/client/device/device.go
Outdated
| "time" | ||
|
|
||
| "github.com/sirupsen/logrus" | ||
| "github.com/zitadel/oidc/v3/pkg/oidc" |
There was a problem hiding this comment.
Please move the import to the lower block, with the other same-module import.
There was a problem hiding this comment.
Done
Could you please take a look
|
@muhlemmer pls review this again, thanks! |
|
🎉 This PR is included in version 3.45.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
is this PR cause the problem (at least for Okta)? |
|
@suqin-haha if you're experiencing problems after upgrading this library in your app, please open an issue with clear steps to reproduce, so we can investigate. |
|
I would like to confirm that in this pull request I have added client credentials to the headers for the refresh token and revoke token requests. As a result, the client credentials are now present in both the request body and the headers. For the device authorization request and the device access token request, the client credentials were already included in both places (body and headers) before this PR. |
I have an authentication provider that only accepts client secrets from the request headers.
Because of this, the refresh token and revoke token requests fail — the Authorization header is missing.
This PR adds the Authorization header with the client credentials to those requests.
Additionally, I’ve updated how the header is added in other requests to follow the same approach.
I’d appreciate any feedback and am happy to adjust the PR as needed.