fix: add auth_methods client_secret_basic for refresh token and revok…#803
Open
kufd wants to merge 4 commits intozitadel:mainfrom
Open
fix: add auth_methods client_secret_basic for refresh token and revok…#803kufd wants to merge 4 commits intozitadel:mainfrom
kufd wants to merge 4 commits intozitadel:mainfrom
Conversation
|
cc @elinashoko |
|
heya @kufd thank you for your contribution, we'll review as soon as we can! |
muhlemmer
reviewed
Oct 22, 2025
Collaborator
muhlemmer
left a comment
muhlemmer
left a comment
There was a problem hiding this comment.
@kufd, can you plead amend the description of you PR and clearly state:
- What is the bug being solved. Preferably an issue with a reproducible case
- How is the bug solved
It's hard to understand the problem and the fix looking at the code alone.
Author
|
@muhlemmer Could you please take a look at the PR description? |
|
@muhlemmer pls have a look |
|
@muhlemmer ping pls |
muhlemmer
requested changes
Feb 17, 2026
Collaborator
muhlemmer
left a comment
muhlemmer
left a comment
There was a problem hiding this comment.
Change looks good, thanks. One small formatting comment.
example/client/device/device.go
Outdated
| "time" | ||
|
|
||
| "github.com/sirupsen/logrus" | ||
| "github.com/zitadel/oidc/v3/pkg/oidc" |
Collaborator
There was a problem hiding this comment.
Please move the import to the lower block, with the other same-module import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an authentication provider that only accepts client secrets from the request headers.
Because of this, the refresh token and revoke token requests fail — the Authorization header is missing.
This PR adds the Authorization header with the client credentials to those requests.
Additionally, I’ve updated how the header is added in other requests to follow the same approach.
I’d appreciate any feedback and am happy to adjust the PR as needed.