Closed
Conversation
TakaRikka
reviewed
Oct 31, 2024
modules/boot/src/utils/hook.cpp
Outdated
Comment on lines
+205
to
+207
| if (scene == PROC_OPENING_SCENE ) { | ||
| g_PreLoopListener->addListener(GZ_endlessNightOnTitle); | ||
| } |
Contributor
There was a problem hiding this comment.
idk if this is a very good place for this. it'd probably be better hooked onto something like dComIfG_resetToOpening or dComIfG_changeOpeningScene.
Contributor
Author
There was a problem hiding this comment.
i don't see a better way to handle this because if a save is loaded in title screen i don't see how remove the listner
modules/boot/src/utils/hook.cpp
Outdated
Comment on lines
+218
to
+220
| if (scene == PROC_OPENING_SCENE) { | ||
| g_PreLoopListener->removeListener(GZ_endlessNightOnTitle); | ||
| } |
Contributor
There was a problem hiding this comment.
same with this, should probably be hooked somewhere else that's more relevant to the title screen and not just general gameplay state
1.2.0 dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at adding 'Endless Night' to the title screen. Need help to see if it's possible to add thunder effects to the title screen and maybe a darker color palette?