Skip to content

Merge some of my features into 1.2#92

Merged
Pheenoh merged 16 commits intozsrtp:1.2.0-devfrom
qwertyquerty:qwerty-merge
Aug 25, 2025
Merged

Merge some of my features into 1.2#92
Pheenoh merged 16 commits intozsrtp:1.2.0-devfrom
qwertyquerty:qwerty-merge

Conversation

@qwertyquerty
Copy link

No description provided.

#define FREE_CAM_BUTTONS (CButton::Z | CButton::B | CButton::A)
#define MOVE_LINK_BUTTONS (CButton::L | CButton::R | CButton::Y)
#define FRAME_PAUSE_BUTTONS (CButton::R | CButton::DPAD_UP)
#define FRAME_PAUSE_BUTTONS (CButton::R | CButton::DPAD_LEFT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this a request somebody had?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah i just thought it was annoying that it was the same combo as teleport

return actorData;
}

fopAc_ac_c* find_actor_idx(predicate_t const& predicate, u32 idx) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be able to be replaced with fopAcM_SearchByName which does pretty much exactly this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that not just get you the first instance of the actor? I need to be able to get the first and second

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use fopAcM_Search and provide a callback function (signature void* callback(void* iterated_actor, void* data)) to run checks on the iterated actor, like it's id or position or whatever to differentiate the two

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing these werent meant to be added

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh they dont hurt anything but I can remove them if you'd like

@qwertyquerty qwertyquerty requested a review from TakaRikka August 25, 2025 05:28
@Pheenoh Pheenoh merged commit cc2c699 into zsrtp:1.2.0-dev Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants