Added shared.cmd_opts.data_dir prefix to "outputs" and "log" paths.#14443
Closed
canoalberto wants to merge 1 commit intoAUTOMATIC1111:devfrom
Closed
Added shared.cmd_opts.data_dir prefix to "outputs" and "log" paths.#14443canoalberto wants to merge 1 commit intoAUTOMATIC1111:devfrom
canoalberto wants to merge 1 commit intoAUTOMATIC1111:devfrom
Conversation
Collaborator
|
related conversation lol didn't realize you basically have the same idea as me |
Collaborator
|
I made an alternative implementation with some changes see PR #14446 namely truncating the path to CWD when possible (so if one is not using I added you as co-author |
Owner
|
I merged the other one. Just was wew proposes, I'd rather not absolute paths to config by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added shared.cmd_opts.data_dir prefix to "outputs" and "log" paths.
Fixes the issue where hardcoded default "outputs" and "log" paths may not be writable and enables placing them under
--data-diroption path.Screenshots/videos:
NA
Checklist: