Merged
Conversation
utli.truncate_path(target_path, base_path) return the target_path relative to base_path if target_path is a sub path of base_path else return the absolute path
4 tasks
Co-Authored-By: Alberto Cano <34340962+canoalberto@users.noreply.github.com>
56d805f to
892e703
Compare
AUTOMATIC1111
approved these changes
Dec 30, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
alternative implementation of #14443 Added shared.cmd_opts.data_dir prefix to "outputs" and "log" paths.
achieve the same thing with minor differences being
this has the advantage of making existing config.json more usable if webui is moved
other minor change
truncate_path()default_output_dir(I guess this can be reused by extensions)def webpath(fn)simplifying it(I know I probably shouldn't have bundle this one in this PR)
Implications
this change could potentially have a minor impact on existing users
if the user decides to create a new configuration file and happens to be using --data-dir
but they also wish for some reason the output to be in the webui root
these user will have to set the output to webui root manually
but for existing users that are using existing configuration file there will be no impact, as this only changes the default output path not the current path
Checklist: