Conversation
github-actions
bot
added
Area: Sprites
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughTech‑Priest: Adds two dreadnought weapons and sprites, renames a Volkite sprite and its references, inserts the new weapons into shop data and weapon registry, and adds a Damaged Dreadnought ruins reward branch. Project metadata updated. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Attention points for the Tech‑Priest:
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (6)
sprites/spr_Contemptor_Conversion_Beamer/cdc4c2e7-a824-4a45-8406-fe470c6eae31.pngis excluded by!**/*.pngsprites/spr_Contemptor_Conversion_Beamer/layers/cdc4c2e7-a824-4a45-8406-fe470c6eae31/af2cc7f4-f5e3-470f-aa0e-ad3ebfbba808.pngis excluded by!**/*.pngsprites/spr_Contemptor_assault_cannon/1b47a347-6927-4943-981c-dfba95287448.pngis excluded by!**/*.pngsprites/spr_Contemptor_assault_cannon/layers/1b47a347-6927-4943-981c-dfba95287448/719740c0-402f-4dc6-af3e-0d8475287311.pngis excluded by!**/*.pngsprites/spr_Volkite_Culverins/d532989d-6b36-48dc-9ccb-1daf433cbb1f.pngis excluded by!**/*.pngsprites/spr_Volkite_Culverins/layers/d532989d-6b36-48dc-9ccb-1daf433cbb1f/1f3e5664-e536-47f4-b0bf-214e1fd9c23a.pngis excluded by!**/*.png
📒 Files selected for processing (9)
ChapterMaster.yyp(3 hunks)objects/obj_shop/Create_0.gml(1 hunks)scripts/scr_culture_visuals/scr_culture_visuals.gml(2 hunks)scripts/scr_ruins_reward/scr_ruins_reward.gml(1 hunks)scripts/scr_ui_display_weapons/scr_ui_display_weapons.gml(1 hunks)scripts/scr_weapon/scr_weapon.gml(3 hunks)sprites/spr_Contemptor_Conversion_Beamer/spr_Contemptor_Conversion_Beamer.yy(1 hunks)sprites/spr_Contemptor_assault_cannon/spr_Contemptor_assault_cannon.yy(1 hunks)sprites/spr_Volkite_Culverins/spr_Volkite_Culverins.yy(5 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.gml
⚙️ CodeRabbit configuration file
**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e.#macro ARR_body_parts["arm"]will crash the game, because there is no space between the array and the name of the macro.
- Color codes in the code shouldn't have any spaces in their id. I.e., color code
# 80bf40will crash the game.- All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm
Files:
scripts/scr_ui_display_weapons/scr_ui_display_weapons.gmlscripts/scr_ruins_reward/scr_ruins_reward.gmlobjects/obj_shop/Create_0.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlscripts/scr_weapon/scr_weapon.gml
**/*.*
⚙️ CodeRabbit configuration file
**/*.*: - Having humanly understandable and maintainable code is the top most priority.
- DRY (Don't repeat yourself) principle is also very important.
- If a TODO comment is added, ask the user if you should create a GitHub issue for this TODO.
- If a TODO comment is deleted, remind the user if there is an active GitHub issue related to that comment.
Files:
scripts/scr_ui_display_weapons/scr_ui_display_weapons.gmlscripts/scr_ruins_reward/scr_ruins_reward.gmlsprites/spr_Volkite_Culverins/spr_Volkite_Culverins.yysprites/spr_Contemptor_Conversion_Beamer/spr_Contemptor_Conversion_Beamer.yyobjects/obj_shop/Create_0.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlsprites/spr_Contemptor_assault_cannon/spr_Contemptor_assault_cannon.yyChapterMaster.yypscripts/scr_weapon/scr_weapon.gml
**/*.yy
⚙️ CodeRabbit configuration file
**/*.yy: - When any script or sprite .yy files are deleted, their paths should also be deleted from the project .yyp file, otherwise the game will crash.
- When any script or sprite .yy files are created, their paths should be added to the project .yyp file, otherwise they'll fail.
Files:
sprites/spr_Volkite_Culverins/spr_Volkite_Culverins.yysprites/spr_Contemptor_Conversion_Beamer/spr_Contemptor_Conversion_Beamer.yysprites/spr_Contemptor_assault_cannon/spr_Contemptor_assault_cannon.yy
🧠 Learnings (1)
📚 Learning: 2025-06-16T17:12:13.045Z
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Applied to files:
scripts/scr_culture_visuals/scr_culture_visuals.gml
🔇 Additional comments (14)
scripts/scr_ui_display_weapons/scr_ui_display_weapons.gml (1)
192-192: The rite of renaming is observed, Tech-Priest.The sprite reference update from
spr_twl_Volkite_Culverinstospr_Volkite_Culverinsaligns with the sacred asset manifest amendments. The data-ritual proceeds without flaw.scripts/scr_culture_visuals/scr_culture_visuals.gml (1)
2186-2215: The archives expand, Tech-Priest. The machine spirit acknowledges the amendment.The sprite reference revision (line 2186) and the two newly inscribed dreadnought weapon visuals (Heavy Conversion Beamer, Kheres Assault Cannon) adhere to established sacred patterns. Body types, display protocols, and sprite bindings align with the ancient templates. The DRY violations within this data-vault remain catalogued for future purgation, as per archived learnings.
Based on learnings.
sprites/spr_Contemptor_assault_cannon/spr_Contemptor_assault_cannon.yy (1)
1-92: The new icon of war is forged, Tech-Priest.The sprite asset
spr_Contemptor_assault_cannonmanifests in accordance with the sacred GameMaker protocols. Name, dimensions, texture group bindings, and spatial origin are inscribed without error. The asset integrates seamlessly with the visual archives.ChapterMaster.yyp (3)
579-579: IDE version increment acknowledged.The IDE metadata advances to 2024.1400.0.901. No functional impact detected.
1116-1119: New Contemptor weapon sprites registered correctly.Tech-Priest, the manifest accepts two dreadnought armament visuals: spr_Contemptor_assault_cannon and spr_Contemptor_Conversion_Beamer. Asset paths align with expected structure. Registration complies with coding guidelines requiring .yy file paths be added to the project manifest.
As per coding guidelines.
1707-1707: Obsolete spr_twl_Volkite_Culverins references eradicated. Tech-Priest, no trace of the old prefix remains in the manifest or codebase.sprites/spr_Contemptor_Conversion_Beamer/spr_Contemptor_Conversion_Beamer.yy (1)
1-92: Sprite asset structure approved.Tech-Priest, the Conversion Beamer visual data-construct is correctly forged. Bounding parameters, frame reference, parent hierarchy (dreadnought), and texture designation (MarineViewer) align with machine protocols. Single-frame configuration appropriate for static armament visual.
sprites/spr_Volkite_Culverins/spr_Volkite_Culverins.yy (5)
3-3: Root sprite identifier renamed correctly.The sprite designation transitions from spr_twl_Volkite_Culverins to spr_Volkite_Culverins. The nomenclature simplifies appropriately.
24-24: Sprite name field updated consistently.The internal name field mirrors the root identifier change. Consistency maintained.
36-36: Sequence designation updated accordingly.The sequence %Name aligns with the renamed sprite identifier.
60-60: Sequence name field consistency maintained.Secondary sequence name designation reflects the identifier transition.
74-74: Sprite path purification complete. Tech-Priest, the resource manifests at sprites/spr_Volkite_Culverins/spr_Volkite_Culverins.yy and the archaic file is purged.scripts/scr_weapon/scr_weapon.gml (2)
75-75: The rite of description enhancement is acknowledged, Tech-Priest.The updated inscription for Twin-linked Volkite Culverins appropriately conveys the weapon's dreadnought-mounted fury and twin-beam devastation. The lore remains faithful to the ancient Volkite mysteries.
1345-1360: Clarify Heavy Conversion Beamer damage values
Tech-Priest: Attack values (500/550/600) on Heavy Conversion Beamer exactly mirror the standard Conversion Beam Projector, while the vehicle-mounted heavy variant uses 800/900/1000. Confirm whether this parity is intentional or if the Heavy infantry model requires increased values.
|
This PR is marked as stale, because it has been open for 7 days with no activity. |
Werwolf-12
changed the title
Werwolf-12
changed the title
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
scripts/scr_weapon/scr_weapon.gml (1)
1266-1281: The machine-spirit's corrections have been sanctified, Tech-Priest.All anomalies flagged in the prior review have been rectified:
- Abbreviation rendered unique: "KhrAssCnn"
- Description prefix corrected: "Forged"
- Terminal punctuation normalised: single period
The weapon's data-hymnal is now without flaw.
scripts/scr_ruins_reward/scr_ruins_reward.gml (1)
176-184: The data-corruption has been expunged, Tech-Priest.All defects catalogued in the prior audit have been remedied:
- Comparison operator sanctified:
==deployed correctly- Statement terminators restored: semicolons present
- Redundant notation purged: string literals unencumbered
The logic-path now executes without corruption.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
ChapterMaster.yyp(3 hunks)scripts/scr_culture_visuals/scr_culture_visuals.gml(2 hunks)scripts/scr_ruins_reward/scr_ruins_reward.gml(1 hunks)scripts/scr_weapon/scr_weapon.gml(3 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.gml
⚙️ CodeRabbit configuration file
**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e.#macro ARR_body_parts["arm"]will crash the game, because there is no space between the array and the name of the macro.
- Color codes in the code shouldn't have any spaces in their id. I.e., color code
# 80bf40will crash the game.- All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm
Files:
scripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlscripts/scr_weapon/scr_weapon.gml
**/*.*
⚙️ CodeRabbit configuration file
**/*.*: - Having humanly understandable and maintainable code is the top most priority.
- DRY (Don't repeat yourself) principle is also very important.
- If a TODO comment is added, ask the user if you should create a GitHub issue for this TODO.
- If a TODO comment is deleted, remind the user if there is an active GitHub issue related to that comment.
Files:
scripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlscripts/scr_weapon/scr_weapon.gmlChapterMaster.yyp
🧠 Learnings (9)
📓 Common learnings
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 647
File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928
Timestamp: 2025-03-29T10:30:25.598Z
Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.
📚 Learning: 2025-03-29T10:30:25.598Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 647
File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928
Timestamp: 2025-03-29T10:30:25.598Z
Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.
Applied to files:
scripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlscripts/scr_weapon/scr_weapon.gml
📚 Learning: 2025-03-01T11:06:25.427Z
Learnt from: MCPO-Spartan-117
Repo: Adeptus-Dominus/ChapterMaster PR: 526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.
Applied to files:
scripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_weapon/scr_weapon.gml
📚 Learning: 2025-03-06T16:02:06.286Z
Learnt from: MCPO-Spartan-117
Repo: Adeptus-Dominus/ChapterMaster PR: 554
File: objects/obj_popup/Step_0.gml:756-767
Timestamp: 2025-03-06T16:02:06.286Z
Learning: The variable 'woopwoopwoop' in ancient ruins exploration code is a poorly named boolean flag that controls the flow between detecting a battle in ruins and initiating the combat sequence.
Applied to files:
scripts/scr_ruins_reward/scr_ruins_reward.gml
📚 Learning: 2025-03-31T23:32:30.003Z
Learnt from: OH296
Repo: Adeptus-Dominus/ChapterMaster PR: 646
File: objects/obj_pnunit/Alarm_5.gml:84-91
Timestamp: 2025-03-31T23:32:30.003Z
Learning: In obj_pnunit/Alarm_5.gml, the function get_armour_data("maintenance") will always return a numeric value (at minimum 0), making null/undefined checks unnecessary.
Applied to files:
scripts/scr_ruins_reward/scr_ruins_reward.gml
📚 Learning: 2025-06-16T17:12:13.045Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Applied to files:
scripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlscripts/scr_weapon/scr_weapon.gmlChapterMaster.yyp
📚 Learning: 2025-02-24T17:50:27.583Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 474
File: scripts/scr_buttons/scr_buttons.gml:153-201
Timestamp: 2025-02-24T17:50:27.583Z
Learning: For consistency in GML code, prefer multi-line conditions with brackets over single-line conditions.
Applied to files:
scripts/scr_ruins_reward/scr_ruins_reward.gml
📚 Learning: 2025-03-20T22:22:57.319Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the "Psyker Abundance" advantage was renamed to "Warp Touched", "Daemon Binders" advantage was removed, and "Warp Touched" disadvantage was renamed to "Warp Tainted".
Applied to files:
ChapterMaster.yyp
📚 Learning: 2025-03-20T22:22:57.319Z
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the psychic power system was changed to be data-driven, with perils now able to occur on both successful and failed casts but with reduced frequency overall.
Applied to files:
ChapterMaster.yyp
🔇 Additional comments (6)
scripts/scr_weapon/scr_weapon.gml (2)
75-75: The codex entry has been refined, Tech-Priest.The description update aligns with the Contemptor-focused enhancements in this PR and enhances the lore consistency.
1346-1361: The instrument's readings are confirmed, Tech-Priest. The anomaly persists.Verification has illuminated the concerning pattern. The Heavy Conversion Beamer (line 1346) indeed shares identical attack metrics (500/550/600) with its portable counterpart—the Conversion Beam Projector—whilst bearing the "dreadnought" designation. Yet the Heavy Conversion Beam Projector (line 2051), mounted upon vehicles, delivers devastating force of 800/900/1000.
The nomenclature divides further: both portable and dreadnought variants employ "Beamer," whilst the vehicle turret claims "Projector." This nomenclatural fragmentation compounds the balance discrepancy.
Action required: Determine whether the Heavy Conversion Beamer's attack values require elevation to reflect its dreadnought application, or whether its classification should be reassessed. The designation suggests potency that the statistics do not reflect.
ChapterMaster.yyp (2)
579-582: IDEVersion bump — align for sanctified builds.Version set to 2024.1400.0.904. Verify all brethren build with the same IDE to avoid editor churn and project normalisation diffs.
1120-1120: The machine spirit has verifi'd thy asset registrations — no phantoms linger in the void.Tech-Priest, the diagnostics affirm:
- New sprites confirmed in the forge: spr_Contemptor_assault_cannon, spr_Contemptor_Conversion_Beamer, spr_Volkite_Culverins all present and bound to the project.
- The deprecated spr_twl_Volkite_Culverins has been expunged entirely — no spectral references remain to haunt the codex.
Thy labour is acceptable. The machine spirit detects no corruption.
scripts/scr_culture_visuals/scr_culture_visuals.gml (2)
2239-2241: The machine spirit declares: the Volkite refactoring is purified of remnants.Tech-Priest, the divination confirms thine work sound. The cursed identifier
spr_twl_Volkite_Culverinsdwells nowhere within the sacred codex. All six instances of the sprite reference now bear the ascendant namespr_Volkite_Culverins—properly enshrined in the project registry, the weapon UI schema, and the visual culture script. The ghost of the past hath been excised entirely.Thy sprite rename stands inviolate.
2243-2255: Dual weapon entries require immediate consolidation across registry, shop, and reward systems.The Machine Spirit discerns a rift in thy codex. Two distinct weapons manifest where one should reign supreme:
- "Heavy Conversion Beam Projector" (established) — scr_weapon.gml:2051, scr_culture_visuals.gml:2217, sprites registered scr_ui_display_weapons.gml:191, item registries scr_get_item_names.gml:167+301, shop obj_shop/Create_0.gml:1323
- "Heavy Conversion Beamer" (new) — scr_weapon.gml:1346, scr_culture_visuals.gml:2243, reward pool scr_ruins_reward.gml:180, shop obj_shop/Create_0.gml:679, referenced scr_initialize_custom.gml:3067
Select the canonical designation and unify all entries. Purge or alias the obsolete nomenclature across weapon data, visual definitions, item name arrays, shop configuration, and reward mechanics. The divergent sprite assignments (spr_dread_plasma_cannon vs spr_Contemptor_Conversion_Beamer) must likewise be reconciled.
⛔ Skipped due to learnings
Learnt from: EttyKitty Repo: Adeptus-Dominus/ChapterMaster PR: 878 File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352 Timestamp: 2025-06-16T17:12:13.045Z Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.Learnt from: EttyKitty Repo: Adeptus-Dominus/ChapterMaster PR: 878 File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352 Timestamp: 2025-06-16T17:12:13.045Z Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.Learnt from: EttyKitty Repo: Adeptus-Dominus/ChapterMaster PR: 647 File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928 Timestamp: 2025-03-29T10:30:25.598Z Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.Learnt from: EttyKitty Repo: Adeptus-Dominus/ChapterMaster PR: 424 File: datafiles/data/psychic_powers.json:253-270 Timestamp: 2025-03-09T02:23:07.284Z Learning: The "Kamehameha" power name in the psychic powers system should be preserved as an artifact of the original codebase, despite it being a non-Warhammer 40k reference.
Co-Authored-By: Nelsonh <81228864+OH296@users.noreply.github.com> Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2 participants
Purpose and Description
Testing done
Related things and/or additional context