feat: New Volkite and Bolt weapons HH era#878
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughSummary by CodeRabbit
WalkthroughBy the Omnissiah’s will, this update integrates a new arsenal of 30k-era weapons into the system, including Volkite and ancient Bolter variants. Eight new weapon sprites are sanctified, corresponding data entries are inscribed in the project and visual data scripts, and weapon definitions are appended to the global weapon registry. Minimal non-functional comments are added elsewhere. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Area: Sprites
|
I don't really understand why this PR has 700 yy files changed. Hm… |
EttyKitty
force-pushed
the
Volkite+boltPack
branch
from
0c75cfb to
1737e03
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
♻️ Duplicate comments (1)
sprites/spr_weapon_volkite_culverin/spr_weapon_volkite_culverin.yy (1)
27-30: YYP linkage checkEchoing earlier rites: confirm the culverin sprite is declared inside the project’s
.yyp.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (16)
sprites/spr_weapon_mars_hbolt/473a7284-a688-484d-91d4-96d25b326cfd.pngis excluded by!**/*.pngsprites/spr_weapon_mars_hbolt/layers/473a7284-a688-484d-91d4-96d25b326cfd/cb2bbe01-35ef-4dc1-b409-a1cbfe34ce5a.pngis excluded by!**/*.pngsprites/spr_weapon_phobos_bolt_pistol/7bf54d5b-eb4f-4225-8043-c7bbdfefe28f.pngis excluded by!**/*.pngsprites/spr_weapon_phobos_bolt_pistol/layers/7bf54d5b-eb4f-4225-8043-c7bbdfefe28f/874c87bf-544a-4c32-a371-509dc9981ec4.pngis excluded by!**/*.pngsprites/spr_weapon_phobos_bolter/0feb2b87-1efd-47dd-9f23-14a4113b369c.pngis excluded by!**/*.pngsprites/spr_weapon_phobos_bolter/layers/0feb2b87-1efd-47dd-9f23-14a4113b369c/664d1dec-58bd-4b0a-abf0-6249a1377b2b.pngis excluded by!**/*.pngsprites/spr_weapon_tigris_combi/7078d58a-3619-44c5-bbe0-4449064aeaa4.pngis excluded by!**/*.pngsprites/spr_weapon_tigris_combi/layers/7078d58a-3619-44c5-bbe0-4449064aeaa4/c71b0c2f-0e0d-4b9e-aa10-73d13c7796a6.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_caliver/746312be-a5f0-47ac-a783-e19dcde061a8.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_caliver/layers/746312be-a5f0-47ac-a783-e19dcde061a8/7661b2ed-1571-406e-8395-989f5935e303.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_charger/b91b3e74-91d9-46d1-b954-65c7a49d8b7d.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_charger/layers/b91b3e74-91d9-46d1-b954-65c7a49d8b7d/e98a4021-39fb-45ff-81e5-78fc2e913c77.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_culverin/27b95a4c-b7c0-4f2e-aa03-ece8e4e50432.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_culverin/layers/27b95a4c-b7c0-4f2e-aa03-ece8e4e50432/7e7d708c-6c89-45d1-b800-7d518f4ba3cd.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_serpenta/73214df0-5c58-4848-aae2-d68778f0fe65.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_serpenta/layers/73214df0-5c58-4848-aae2-d68778f0fe65/9b9d7ab4-6736-4bc5-b3cc-4d650606eedb.pngis excluded by!**/*.png
📒 Files selected for processing (12)
ChapterMaster.yyp(2 hunks)objects/obj_shop/Create_0.gml(1 hunks)scripts/scr_culture_visuals/scr_culture_visuals.gml(1 hunks)scripts/scr_weapon/scr_weapon.gml(1 hunks)sprites/spr_weapon_mars_hbolt/spr_weapon_mars_hbolt.yy(1 hunks)sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy(1 hunks)sprites/spr_weapon_phobos_bolter/spr_weapon_phobos_bolter.yy(1 hunks)sprites/spr_weapon_tigris_combi/spr_weapon_tigris_combi.yy(1 hunks)sprites/spr_weapon_volkite_caliver/spr_weapon_volkite_caliver.yy(1 hunks)sprites/spr_weapon_volkite_charger/spr_weapon_volkite_charger.yy(1 hunks)sprites/spr_weapon_volkite_culverin/spr_weapon_volkite_culverin.yy(1 hunks)sprites/spr_weapon_volkite_serpenta/spr_weapon_volkite_serpenta.yy(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
`**/*.gml`: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. `#macro ARR_body_parts["arm"]` will crash the ...
**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e.#macro ARR_body_parts["arm"]will crash the game, because there is no space between the array and the name of the macro.
- Color codes in the code shouldn't have any spaces in their id. I.e., color code
# 80bf40will crash the game.- All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm
objects/obj_shop/Create_0.gmlscripts/scr_weapon/scr_weapon.gmlscripts/scr_culture_visuals/scr_culture_visuals.gml
`**/*.*`: - Having humanly understandable and maintainable code is always the top most priority. - DRY (Don't repeat yourself) principle is also very important. - Ensure that the c...
**/*.*: - Having humanly understandable and maintainable code is always the top most priority.
- DRY (Don't repeat yourself) principle is also very important.
- Ensure that the code is compliant with the CODE_STYLE.MD: https://github.com/Adeptus-Dominus/ChapterMaster/blob/main/docs/CODE_STYLE.md
- If a TODO comment is added, ask the user if you should create a GitHub issue for this TODO.
- If a TODO comment is deleted, remind the user if there is an active GitHub issue related to that comment.
objects/obj_shop/Create_0.gmlsprites/spr_weapon_volkite_charger/spr_weapon_volkite_charger.yysprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yysprites/spr_weapon_tigris_combi/spr_weapon_tigris_combi.yysprites/spr_weapon_volkite_caliver/spr_weapon_volkite_caliver.yysprites/spr_weapon_volkite_culverin/spr_weapon_volkite_culverin.yysprites/spr_weapon_mars_hbolt/spr_weapon_mars_hbolt.yysprites/spr_weapon_volkite_serpenta/spr_weapon_volkite_serpenta.yysprites/spr_weapon_phobos_bolter/spr_weapon_phobos_bolter.yyscripts/scr_weapon/scr_weapon.gmlscripts/scr_culture_visuals/scr_culture_visuals.gmlChapterMaster.yyp
`**/*.yy`: - When any script or sprite .yy files are deleted, their paths should also be deleted from the .yyp file, otherwise the game will crash. - When any script or sprite .yy ...
**/*.yy: - When any script or sprite .yy files are deleted, their paths should also be deleted from the .yyp file, otherwise the game will crash.
- When any script or sprite .yy files are created, their paths should be added to the .yyp file, otherwise they'll fail.
sprites/spr_weapon_volkite_charger/spr_weapon_volkite_charger.yysprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yysprites/spr_weapon_tigris_combi/spr_weapon_tigris_combi.yysprites/spr_weapon_volkite_caliver/spr_weapon_volkite_caliver.yysprites/spr_weapon_volkite_culverin/spr_weapon_volkite_culverin.yysprites/spr_weapon_mars_hbolt/spr_weapon_mars_hbolt.yysprites/spr_weapon_volkite_serpenta/spr_weapon_volkite_serpenta.yysprites/spr_weapon_phobos_bolter/spr_weapon_phobos_bolter.yy
🔇 Additional comments (12)
ChapterMaster.yyp (3)
1663-1663: Asset sanctified: spr_weapon_mars_hbolt
The new sprite entry adheres to naming conventions and correct path placement.
1667-1668: Assets sanctified: spr_weapon_phobos_bolt_pistol & spr_weapon_phobos_bolter
Both entries follow the established sprite naming and are alphabetically positioned.
1699-1703: Assets sanctified: spr_weapon_tigris_combi and Volkite variants
All new Volkite sprite entries are correctly named and ordered within the resource list.sprites/spr_weapon_volkite_caliver/spr_weapon_volkite_caliver.yy (1)
27-30: Verify YYP registration of the new spriteThe machine-spirits grow angry when a freshly-forged sprite is not referenced in
ChapterMaster.yyp. Please confirm that the path
sprites/spr_weapon_volkite_caliver/spr_weapon_volkite_caliver.yyhas been appended to the project file; otherwise the game will refuse to compile.
#!/bin/bash # Confirm the sprite is declared in the project file rg -n '"spr_weapon_volkite_caliver"' ChapterMaster.yypsprites/spr_weapon_mars_hbolt/spr_weapon_mars_hbolt.yy (1)
27-30: Confirm sprite entry in.yypAs with the previous resource, ensure this heavy bolter sprite is present in
ChapterMaster.yyp; omission leads to a fatal crash at run-time.sprites/spr_weapon_phobos_bolt_pistol/spr_weapon_phobos_bolt_pistol.yy (1)
45-49: By the Omnissiah’s decree, we shall audit all weapon‐sprite origin settings for alignment consistency.#!/bin/bash echo "— Scanning all weapon sprite .yy files for 'origin' values —" files=$(find sprites -type f -name "spr_weapon_*.yy") for f in $files; do echo "" echo "File: $f" rg -n -C1 '"origin"' "$f" || echo " (no origin field)" donescripts/scr_weapon/scr_weapon.gml (1)
4-19: Tag capitalisation & key spellingThe tag
"Volkite"is capitalised, whilst existing tags are lower-case ("plasma","bolt", etc.). If downstream look-ups are case-sensitive this will orphan the new data. Additionally, the keyspliis used throughout; ensure that this matches the field expected by combat logic (some legacy code usesspl). Verify both before deployment.sprites/spr_weapon_tigris_combi/spr_weapon_tigris_combi.yy (1)
1-111: Register the sprite path inChapterMaster.yyp
The Adeptus Mechanicus reminds you that every newly forged.yyasset must be referenced in the project’s.yyp; omission will result in a fatal asset-load failure at runtime. Please verify the path has been appended underresources:.Additionally, confirm that
origin : 0(top-left) matches the weapon-draw code; most ranged weapons in this repo use a centred origin (9).sprites/spr_weapon_volkite_serpenta/spr_weapon_volkite_serpenta.yy (1)
1-111: Path registration + origin check
Repeat the cogitation cycles: ensure the sprite entry is present inChapterMaster.yyp, else the Omnissiah will not bless the build.
Also verify thatorigin : 0is intentional for this weapon class.sprites/spr_weapon_volkite_charger/spr_weapon_volkite_charger.yy (1)
1-111: Same ritual applies: link the sprite and review origin
Confirm the.yypath is recorded in the.yyp, and thatorigin : 0aligns with drawing offsets.sprites/spr_weapon_phobos_bolter/spr_weapon_phobos_bolter.yy (2)
45-50: Mixed origin settings—double-check consistency
Unlike the other new sprites, this resource usesorigin : 9(centre). Validate that the code handling Phobos Bolters expects this pivot, else weapon alignment may drift.
1-111: Ensure.yypregistration
As with the other sprites, add the resource path toChapterMaster.yypto avoid loading failures.
3 participants
Added bolt and volkite weapons from 30k. Main reason for this commit is for me to get used to workflow of the project.
Describe your changes/additions
What can/needs to be improved/changed
Testing done
Tested, sprites, descriptions and stats are all as they should be and work well.
Related things and/or additional context