Conversation
- Comments out condemnor bolters on the inquisition trade screen.
|
Warning Rate limit exceeded@EttyKitty has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 52 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes update the trading and mouse interaction logic within the game's menu system. Adjustments were made to the way trade goods are handled, particularly concerning the Inquisition trade items. Specific items, including the "Condemnor Boltgun," have been commented out, indicating they are temporarily disabled due to related crashes. The calculation for trade worth was altered, with lines involving the "Condemnor Boltgun" commented out in both the trade calculation and trade addition functions, preventing specific bonuses or user prompts associated with that item from being executed. Additionally, the previously included fleet count logic has been entirely commented out. The overall structure of the mouse interactions and trade calculations remains intact, with only specific parts being disabled or updated. No changes were made to the exported or public entities. Possibly related PRs
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai can you add todo comments to commented out code parts? |
🧩 Analysis chain@EttyKitty I'll help you add a TODO comment to the commented code. Here's how it should look: // TODO: Condemnor bolter is commented out as it causes crashes when players attempt to buy it.
// This weapon doesn't exist elsewhere in the game. Re-enable once the weapon is properly implemented.
//if (inquisition_trade_screen == 2)
//{
// draw_text_transformed(argument0 + 32, argument1 + 32, "Condemnor Bolter", 0.7, 0.7, 0);
// draw_text_transformed(argument0 + 32, argument1 + 48, "Cost: 35", 0.6, 0.6, 0);
//}This TODO comment clearly explains:
Would you like me to trigger a review to implement this change? 🏁 Script executed: Length of output: 37 🏁 Script executed: Length of output: 3282 @EttyKitty I found three files where Condemnor Bolter related code is commented out. Here are the suggested TODO comments for each location:
// TODO: Condemnor Boltgun is temporarily disabled as it causes crashes when players attempt to buy it.
// Re-enable once the weapon is properly implemented in the game.
// trade_theirs[1]="Condemnor Boltgun";
// trade_disp[1]=20;
// TODO: Condemnor Boltgun worth calculation disabled due to weapon being temporarily removed.
// Re-enable when the weapon is properly implemented.
// if (trade_take[i]="Condemnor Boltgun") then their_worth+=trade_tnum[i]*15;
// TODO: Condemnor Boltgun trade dialog disabled due to weapon being temporarily removed.
// Re-enable when the weapon is properly implemented.
// if (argument0="Condemnor Boltgun"){get_diag_integer("Condemnor Boltguns wanted?",20,"t"+string(thinz),"Condemnor Boltgun");}Would you like me to trigger a review to implement these changes? ✏️ Learnings added
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
objects/obj_controller/Mouse_50.gml(1 hunks)scripts/scr_trade/scr_trade.gml(1 hunks)scripts/scr_trade_add/scr_trade_add.gml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- scripts/scr_trade_add/scr_trade_add.gml
|
@coderabbitai yes, please do that. |
|
@EttyKitty I'll trigger a review to implement the TODO comments as discussed. (｀･ω･´)ゞ ✅ Actions performedReview triggered.
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
@coderabbitai you forgot to add a comment into the |
🧩 Analysis chain@EttyKitty You're right, I apologize for the oversight. I'll trigger a review to add the missing TODO comment in // TODO: Condemnor Boltgun trade dialog disabled due to weapon being temporarily removed.
// Re-enable when the weapon is properly implemented.
// if (argument0="Condemnor Boltgun"){get_diag_integer("Condemnor Boltguns wanted?",20,"t"+string(thinz),"Condemnor Boltgun");}🏁 Script executed: Length of output: 52 🏁 Script executed: Length of output: 429 🏁 Script executed: Length of output: 3684 @EttyKitty Looking at the file content, I can confirm that the TODO comment is indeed missing. I'll trigger another review to add the TODO comment above the commented-out code: // TODO: Condemnor Boltgun trade dialog disabled due to weapon being temporarily removed.
// Re-enable when the weapon is properly implemented.
// if (argument0="Condemnor Boltgun"){get_diag_integer("Condemnor Boltguns wanted?",20,"t"+string(thinz),"Condemnor Boltgun");}✅ Actions performedReview triggered.
|
3 participants
Description of changes
Reasons for changes
Related links
How have you tested your changes?