fix: small bug fixes and fix research tree

[MCPO-Spartan-117]

Description of changes

• Removes duplicate training rate text from the Reclusium
• Fix typo in the trait zealous_faith
• Fix second STC Wargear bonuses
• Fix broken armor tech tree caused by fix: Enhanced Item Accessibility and Progression #463

Reasons for changes

• Broken tech tree.

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

[EttyKitty]

@coderabbitai review

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update condition checks and property definitions across several modules. In the shop object, the logic for unlocking research items now uses equality checks rather than inequality, adjusting how armor and stealth research items are made available. The equipment structure script has been extended with a new property, "maintenance," initialized with a default value and set according to specific tag conditions. This script also refines bonus calculations by switching from one bonus index to another for certain tags. A minor formatting update was applied in the UI advisors script with the addition of a newline at the end of the file. In the traits script, a typographical error was corrected by renaming the key "texhnology" to "technology" within the "zealous_faith" trait definition.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e84320b and 054bae8.

📒 Files selected for processing (4)

• objects/obj_shop/Create_0.gml (2 hunks)
• scripts/scr_equipment_struct/scr_equipment_struct.gml (1 hunks)
• scripts/scr_ui_advisors/scr_ui_advisors.gml (1 hunks)
• scripts/scr_unit_traits/scr_unit_traits.gml (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• scripts/scr_unit_traits/scr_unit_traits.gml
• scripts/scr_ui_advisors/scr_ui_advisors.gml

🔇 Additional comments (4)

scripts/scr_equipment_struct/scr_equipment_struct.gml (3)

25-25: LGTM! Well-structured maintenance system implementation.

The maintenance property is properly integrated with a sensible default value and clear logic for setting maintenance costs for specialized weapons.

Also applies to: 50-54

---

227-231: LGTM! Clear and consistent tooltip implementation.

The maintenance tooltip follows the established pattern and provides clear information about maintenance costs in Forge Points.

---

290-294: LGTM! Fixed STC Wargear bonus application.

The changes correctly implement the second STC Wargear bonuses for fist and plasma weapons, aligning with the PR objectives.

objects/obj_shop/Create_0.gml (1)

1584-1585: LGTM! Fixed armor tech tree progression.

The changes correctly modify the research conditions to ensure proper tech tree progression:

• Ceremite Void Hardening now requires exactly level 2 armor research
• Enhanced Nerve Interfacing now requires exactly level 1 in both stealth and armor research

Also applies to: 1598-1599

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.