Skip to content

feat: Adjust Lamenters starting conditions#555

Merged
OH296 merged 2 commits intoAdeptus-Dominus:mainfrom
EttyKitty:feat/lamenters-adj
Mar 7, 2025
Merged

feat: Adjust Lamenters starting conditions#555
OH296 merged 2 commits intoAdeptus-Dominus:mainfrom
EttyKitty:feat/lamenters-adj

Conversation

@EttyKitty
Copy link
Copy Markdown
Collaborator

@EttyKitty EttyKitty commented Mar 6, 2025

Screenshots

How their composition looked before:
image

How their composition looks rn:
image

Purpose of changes

  • They were not lore friendly in some aspects;
  • Semi-broken due to custom chapter values adding up to chapter traits;
  • Generally just close to unplayable (in a bad way) for no reason.
  • Lamenters in my opinion = suffering on repeat for the whole playthrough. Not getting into the game and quitting because it's an unfun, broken shitshow start.

Describe the solution

  • Change sliders to be lore friendly and look like a BA successor more.
  • Change the recruiting world to feudal, as the only reference about their recruit worlds from the badab codex I found is about the feudal worlds.
  • Wipe their homeworld name, as it doesn't exist.
  • Gave them "Tech-Scavengers", as the lore implies on multiple occasions that they are used to operating without any imperial support, due to bad relationship.
  • Removed the Suspicious trait, because their dispo is already tanked enough, and there is no reason for the Inquisition to be particularly worried about them. They are not the Soul Drinkers.
  • Gave them the Black Rage trait, as at the time the game takes place, it's already known that they are not immune to it.
  • Renamed their flagship to the last known flagship name that should still be alive at this time.
  • Fixed their unit counts, to not clash with the chapter traits.
  • Added a bit of units, as per the closest lore reference, that says that they have around 300 marines at this point. No, 4 more terminators and 40 more veterans will not automatically win the game now.
  • Merged their companies, so that they have 3 at full strength.
  • Renamed their apothecaries to BA names, as per lore references.
  • Removed the arbitrary 30 geneseed lock from them, now they use the sieged count. Because let the boys fucking survive, brother man.
  • Nuked 1 more barge from them, because fuck them. These changes already are too good for them.

Describe alternatives you've considered

Debatable whenever they should have 10 purity and/or stability or not.

Testing done

New game as Lamenters.

Related links

None

Player notes

More lore friendly. More playable. Less broken.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2025

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Updated chapter "Lamenters" with rebalanced attributes—including adjustments to core strengths, homeworld details, and flagship naming.
    • Enhanced unit and specialist configurations with new roles and revised deployment values for improved gameplay variety.
  • Refactor

    • Streamlined internal chapter logic to ensure consistent outcomes during gameplay.

Walkthrough

The pull request implements modifications to the configuration for the "Lamenters" chapter and alters the game logic for handling chapter-specific attributes. In the JSON file, several numeric and textual values have been adjusted, affecting attributes such as strength, purity, stability, and cooperation. Additionally, chapter properties including homeworld, recruiting planet, flagship name, and various combat unit counts have been updated. Changes have also been made to arrays for advantages and disadvantages, as well as to the custom roles section. In the accompanying GML file, the specialised code that previously set the gene_seed based on the "Lamenters" chapter has been removed, integrating the chapter into the general logic pathway. These revisions adjust the chapter's defined characteristics and the corresponding game mechanics for computing traits.

Possibly related PRs

Suggested labels

PR: Fix, Size: Tiny

Suggested reviewers

  • EttyKitty

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Type: Feature Adds something new Size: Small labels Mar 6, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🔭 Outside diff range comments (1)
datafiles/main/chapters/14.JSON (1)

1-246: 🧹 Nitpick (assertive)

JSON Parsing Compliance Advisory
The static analysis hath reported numerous errors—expecting commas and clear property delineations—which are likely due to the inline commentary interwoven through the configuration. Should the build process invoke a strict JSON parser, it may be advisable to purge or relocate these comments to safeguard against parse failures.

🧰 Tools
🪛 Biome (1.9.4)

[error] 6-6: Expected a property but instead found '// 1 - Founding, 2 - Successor, 3 - Other/non-canon/fanmade, 4 - Custom'.

Expected a property here.

(parse)


[error] 7-7: expected , but instead found "points"

Remove "points"

(parse)


[error] 8-8: Expected a property but instead found '// The id of the founding chapter, 0 for unknown or none, 10 for random'.

Expected a property here.

(parse)


[error] 9-9: expected , but instead found "splash"

Remove "splash"

(parse)


[error] 9-9: Expected a property but instead found '// in \images\creation\chapters\splash folder, the img number, 1 being Dark Angels etc.'.

Expected a property here.

(parse)


[error] 10-10: expected , but instead found "icon"

Remove "icon"

(parse)


[error] 10-10: Expected a property but instead found '// in \images\creation\chapters\icons folder, the icon number, 1 being Dark Angels etc.'.

Expected a property here.

(parse)


[error] 11-11: expected , but instead found "icon_name"

Remove "icon_name"

(parse)


[error] 11-11: Expected a property but instead found '// ? dunno what this is used for yet but the icon breaks if you dont use it '.

Expected a property here.

(parse)


[error] 12-12: expected , but instead found "fleet_type"

Remove "fleet_type"

(parse)


[error] 12-12: Expected a property but instead found '// 1= Homeworld, 2 = Fleet based, 3 = Penitent'.

Expected a property here.

(parse)


[error] 13-13: expected , but instead found "strength"

Remove "strength"

(parse)


[error] 13-13: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 14-14: expected , but instead found "purity"

Remove "purity"

(parse)


[error] 14-14: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 15-15: expected , but instead found "stability"

Remove "stability"

(parse)


[error] 15-15: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 16-16: expected , but instead found "cooperation"

Remove "cooperation"

(parse)


[error] 16-16: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 17-17: expected , but instead found "homeworld_exists"

Remove "homeworld_exists"

(parse)


[error] 17-17: Expected a property but instead found '// 1 = true'.

Expected a property here.

(parse)


[error] 18-18: expected , but instead found "recruiting_exists"

Remove "recruiting_exists"

(parse)


[error] 18-18: Expected a property but instead found '// 1 = true'.

Expected a property here.

(parse)


[error] 19-19: expected , but instead found "homeworld_rule"

Remove "homeworld_rule"

(parse)


[error] 19-19: Expected a property but instead found '// 1 = Govenor, 2 = Countries, 3 = Personal Rule'.

Expected a property here.

(parse)


[error] 20-20: expected , but instead found "homeworld"

Remove "homeworld"

(parse)


[error] 20-20: Expected a property but instead found '// one of "Lava" "Desert" "Forge" "Hive" "Death" "Agri" "Feudal" "Temperate" "Ice" "Dead" "Shrine"'.

Expected a property here.

(parse)


[error] 21-21: expected , but instead found "homeworld_name"

Remove "homeworld_name"

(parse)


[error] 21-21: Expected a property but instead found '// Homeworld Planet name, leave blank to autogenerate'.

Expected a property here.

(parse)


[error] 22-22: expected , but instead found "recruit_home_relationship"

Remove "recruit_home_relationship"

(parse)


[error] 22-22: Expected a property but instead found '//recruit from different system'.

Expected a property here.

(parse)


[error] 23-23: expected , but instead found "recruiting"

Remove "recruiting"

(parse)


[error] 23-23: Expected a property but instead found '// one of "Lava" "Desert" "Forge" "Hive" "Death" "Agri" "Feudal" "Temperate" "Ice" "Dead" "Shrine"'.

Expected a property here.

(parse)


[error] 24-24: expected , but instead found "recruiting_name"

Remove "recruiting_name"

(parse)


[error] 24-24: Expected a property but instead found '// Recruiting Planet name, leave blank to autogenerate'.

Expected a property here.

(parse)


[error] 25-25: expected , but instead found "discipline"

Remove "discipline"

(parse)


[error] 25-25: Expected a property but instead found '// one of 'default' 'biomancy' 'pyromancy' 'telekinesis' 'rune Magick''.

Expected a property here.

(parse)


[error] 26-26: expected , but instead found "aspirant_trial"

Remove "aspirant_trial"

(parse)


[error] 26-26: Expected a property but instead found '// one of "BLOODDUEL" "HUNTING" "SURVIVAL" "EXPOSURE" "KNOWLEDGE" "CHALLENGE" "APPRENTICESHIP" '.

Expected a property here.

(parse)


[error] 27-27: expected , but instead found "advantages"

Remove "advantages"

(parse)


[error] 28-28: Expected an array, an object, or a literal but instead found '// leave the first entry blank for now'.

Expected an array, an object, or a literal here.

(parse)


[error] 29-29: expected , but instead found "Assault Doctrine"

Remove "Assault Doctrine"

(parse)


[error] 39-39: Expected an array, an object, or a literal but instead found '// leave the first entry blank for now'.

Expected an array, an object, or a literal here.

(parse)


[error] 40-40: expected , but instead found "Black Rage"

Remove "Black Rage"

(parse)


[error] 57-57: Expected a property but instead found '// 0 - normal, 1 - Breastplate, 2 - Vertical, 3 - Quadrant'.

Expected a property here.

(parse)


[error] 58-58: expected , but instead found "trim_on"

Remove "trim_on"

(parse)


[error] 58-58: expected , but instead found // 0 no, 1 yes for pauldron trim colours. Trim colour will still be used for certain complex livery items

Remove // 0 no, 1 yes for pauldron trim colours. Trim colour will still be used for certain complex livery items

(parse)


[error] 61-61: Expected a property but instead found '//Chapter Staff'.

Expected a property here.

(parse)


[error] 62-62: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 62-62: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 62-62: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 62-62: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 63-63: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 63-63: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 63-63: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 63-63: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 64-64: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 64-64: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 64-64: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 64-64: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 65-65: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 65-65: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 65-65: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 65-66: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 67-67: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 67-67: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 67-67: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 67-67: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 68-68: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 68-68: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 68-68: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 68-68: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 69-69: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 69-69: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 69-69: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 69-69: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 70-70: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 70-70: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 70-70: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 70-70: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 71-71: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 71-71: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 71-71: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 71-71: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 72-72: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 72-72: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 72-72: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 72-72: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 73-73: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 73-73: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 73-73: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 73-73: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 74-74: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 74-74: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 74-74: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 74-74: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 75-75: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 75-75: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 75-75: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 75-75: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 76-76: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 76-76: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 76-76: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 77-77: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 78-78: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 78-78: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 78-78: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 78-78: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 79-79: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 79-79: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 79-79: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 79-79: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 80-80: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 80-80: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 81-81: Expected a property but instead found '// 0 no, 2 yes, 1 doesnt do anything :)'.

Expected a property here.

(parse)


[error] 82-82: expected , but instead found "split_scouts"

Remove "split_scouts"

(parse)


[error] 82-82: Expected a property but instead found '// 0 no, 1 yes. If yes, splits scouts between companies equally. Otherwise all scouts are kept in 10th Company.'.

Expected a property here.

(parse)


[error] 83-83: expected , but instead found "split_vets"

Remove "split_vets"

(parse)


[error] 83-83: expected , but instead found // 0 no, 1 yes. If yes, all veterans are distrubuted equally between companies. Otherwise all veterans are kept in the 1st Company

Remove // 0 no, 1 yes. If yes, all veterans are distrubuted equally between companies. Otherwise all veterans are kept in the 1st Company

(parse)


[error] 80-84: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 84-84: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 85-85: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 85-85: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 85-85: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 85-85: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 86-86: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 86-86: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 86-100: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 100-100: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 101-101: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 101-101: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 102-102: Expected an array, an object, or a literal but instead found '// nothing'.

Expected an array, an object, or a literal here.

(parse)


[error] 103-103: expected , but instead found 60

Remove 60

(parse)


[error] 103-103: Expected an array, an object, or a literal but instead found '// Progenitor faction'.

Expected an array, an object, or a literal here.

(parse)


[error] 104-104: expected , but instead found 15

Remove 15

(parse)


[error] 104-104: Expected an array, an object, or a literal but instead found '// Imperium'.

Expected an array, an object, or a literal here.

(parse)


[error] 105-105: expected , but instead found 20

Remove 20

(parse)


[error] 105-105: Expected an array, an object, or a literal but instead found '// Admech'.

Expected an array, an object, or a literal here.

(parse)


[error] 106-106: expected , but instead found 10

Remove 10

(parse)


[error] 106-106: Expected an array, an object, or a literal but instead found '//Inquisition'.

Expected an array, an object, or a literal here.

(parse)


[error] 107-107: expected , but instead found 25

Remove 25

(parse)


[error] 107-107: Expected an array, an object, or a literal but instead found '// Ecclesiarchy'.

Expected an array, an object, or a literal here.

(parse)


[error] 108-108: expected , but instead found 50

Remove 50

(parse)


[error] 108-108: Expected an array, an object, or a literal but instead found '// Astartes'.

Expected an array, an object, or a literal here.

(parse)


[error] 109-109: expected , but instead found 0

Remove 0

(parse)


[error] 109-109: expected , but instead found // nothing

Remove // nothing

(parse)


[error] 101-110: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 110-110: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 111-111: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 111-111: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 113-113: Expected a property but instead found '//1 Leader, 2 Champion, 3 Psyker,'.

Expected a property here.

(parse)


[error] 114-114: expected , but instead found "melee"

Remove "melee"

(parse)


[error] 114-114: Expected a property but instead found '// 1 twin power fists ... 8 force staff'.

Expected a property here.

(parse)


[error] 115-115: expected , but instead found "ranged"

Remove "ranged"

(parse)


[error] 115-115: Expected a property but instead found '// 1 boltstorm gauntlets ... 7 storm shield'.

Expected a property here.

(parse)


[error] 116-116: expected , but instead found // All chapter masters have the trait Lead by Example by default

Remove // All chapter masters have the trait Lead by Example by default

(parse)


[error] 111-115: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 116-116: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 117-117: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 117-117: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 117-120: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 120-120: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 121-121: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 121-121: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 121-121: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 121-121: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 122-122: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 122-122: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 122-122: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 122-122: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 123-123: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 123-123: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 123-123: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 123-124: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 125-125: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 125-125: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 125-125: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 125-125: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 126-126: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 126-126: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 126-138: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 138-138: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-149: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 140-149: JSON standard does not allow comments.

(parse)


[error] 150-150: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 150-150: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 150-155: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 155-164: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 156-164: JSON standard does not allow comments.

(parse)


[error] 165-165: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 165-165: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 165-170: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 170-176: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 171-176: JSON standard does not allow comments.

(parse)


[error] 177-177: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 177-177: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 177-187: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 187-187: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 188-188: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 188-188: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 188-194: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 194-195: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 195-195: JSON standard does not allow comments.

(parse)


[error] 196-196: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 196-196: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 197-197: Expected an array, an object, or a literal but instead found '// ['.

Expected an array, an object, or a literal here.

(parse)


[error] 196-196: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 197-206: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 202-206: JSON standard does not allow comments.

(parse)


[error] 207-207: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 207-207: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 207-212: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 212-241: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 213-241: JSON standard does not allow comments.

(parse)


[error] 242-242: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 242-242: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 242-242: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 242-242: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 243-243: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 243-243: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 243-243: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 244-245: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b14a381 and 14f12d6.

📒 Files selected for processing (2)
  • datafiles/main/chapters/14.JSON (8 hunks)
  • objects/obj_controller/Create_0.gml (0 hunks)
💤 Files with no reviewable changes (1)
  • objects/obj_controller/Create_0.gml
🧰 Additional context used
🪛 Biome (1.9.4)
datafiles/main/chapters/14.JSON

[error] 13-13: expected , but instead found "strength"

Remove "strength"

(parse)


[error] 13-13: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 14-14: expected , but instead found "purity"

Remove "purity"

(parse)


[error] 14-14: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 15-15: expected , but instead found "stability"

Remove "stability"

(parse)


[error] 15-15: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 16-16: expected , but instead found "cooperation"

Remove "cooperation"

(parse)


[error] 16-16: Expected a property but instead found '// 1-10'.

Expected a property here.

(parse)


[error] 17-17: expected , but instead found "homeworld_exists"

Remove "homeworld_exists"

(parse)


[error] 17-17: Expected a property but instead found '// 1 = true'.

Expected a property here.

(parse)


[error] 18-18: expected , but instead found "recruiting_exists"

Remove "recruiting_exists"

(parse)


[error] 18-18: Expected a property but instead found '// 1 = true'.

Expected a property here.

(parse)


[error] 19-19: expected , but instead found "homeworld_rule"

Remove "homeworld_rule"

(parse)


[error] 19-19: Expected a property but instead found '// 1 = Govenor, 2 = Countries, 3 = Personal Rule'.

Expected a property here.

(parse)


[error] 20-20: expected , but instead found "homeworld"

Remove "homeworld"

(parse)


[error] 20-20: Expected a property but instead found '// one of "Lava" "Desert" "Forge" "Hive" "Death" "Agri" "Feudal" "Temperate" "Ice" "Dead" "Shrine"'.

Expected a property here.

(parse)


[error] 21-21: expected , but instead found "homeworld_name"

Remove "homeworld_name"

(parse)


[error] 21-21: Expected a property but instead found '// Homeworld Planet name, leave blank to autogenerate'.

Expected a property here.

(parse)


[error] 22-22: expected , but instead found "recruit_home_relationship"

Remove "recruit_home_relationship"

(parse)


[error] 22-22: Expected a property but instead found '//recruit from different system'.

Expected a property here.

(parse)


[error] 23-23: expected , but instead found "recruiting"

Remove "recruiting"

(parse)


[error] 23-23: Expected a property but instead found '// one of "Lava" "Desert" "Forge" "Hive" "Death" "Agri" "Feudal" "Temperate" "Ice" "Dead" "Shrine"'.

Expected a property here.

(parse)


[error] 24-24: expected , but instead found "recruiting_name"

Remove "recruiting_name"

(parse)


[error] 24-24: Expected a property but instead found '// Recruiting Planet name, leave blank to autogenerate'.

Expected a property here.

(parse)


[error] 25-25: expected , but instead found "discipline"

Remove "discipline"

(parse)


[error] 25-25: Expected a property but instead found '// one of 'default' 'biomancy' 'pyromancy' 'telekinesis' 'rune Magick''.

Expected a property here.

(parse)


[error] 26-26: expected , but instead found "aspirant_trial"

Remove "aspirant_trial"

(parse)


[error] 26-26: Expected a property but instead found '// one of "BLOODDUEL" "HUNTING" "SURVIVAL" "EXPOSURE" "KNOWLEDGE" "CHALLENGE" "APPRENTICESHIP" '.

Expected a property here.

(parse)


[error] 27-27: expected , but instead found "advantages"

Remove "advantages"

(parse)


[error] 28-28: Expected an array, an object, or a literal but instead found '// leave the first entry blank for now'.

Expected an array, an object, or a literal here.

(parse)


[error] 29-29: expected , but instead found "Assault Doctrine"

Remove "Assault Doctrine"

(parse)


[error] 40-40: expected , but instead found "Black Rage"

Remove "Black Rage"

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-149: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 244-245: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

🔇 Additional comments (7)
datafiles/main/chapters/14.JSON (7)

27-32: Advantages Array Modification
The advantages array now proudly displays "Tech-Scavengers", replacing the erstwhile entry. This alteration reflects the chapter’s newfound operational independence and inter-departmental synergy. Ensure that all references to this trait are synchronised throughout the configuration.

🧰 Tools
🪛 Biome (1.9.4)

[error] 27-27: expected , but instead found "advantages"

Remove "advantages"

(parse)


[error] 28-28: Expected an array, an object, or a literal but instead found '// leave the first entry blank for now'.

Expected an array, an object, or a literal here.

(parse)


[error] 29-29: expected , but instead found "Assault Doctrine"

Remove "Assault Doctrine"

(parse)


38-41: Disadvantages Array Update
The entry "Black Rage" now occupies its rightful place in the disadvantages array, supplanting the previous trait. This change is consistent with the grim fate that haunts these warriors. Validate that the trait’s in-game effects are adjusted in step with this configuration shift.

🧰 Tools
🪛 Biome (1.9.4)

[error] 39-39: Expected an array, an object, or a literal but instead found '// leave the first entry blank for now'.

Expected an array, an object, or a literal here.

(parse)


[error] 40-40: expected , but instead found "Black Rage"

Remove "Black Rage"

(parse)


139-139: Flagship Name Revision
The flagship has been rechristened "Mater Lachrymarum", a name that befits the mournful majesty of the Lamenters. This nomenclatural change is well executed and in harmony with the updated lore.

🧰 Tools
🪛 Biome (1.9.4)

[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-139: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 139-149: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


150-155: Adjustment of Extra Ships
The "battle_barges" count has been reduced to -3, reflecting a recalibrated fleet composition. This decrement is a precise modification to the chapter’s martial assets; ensure that it reverberates correctly across deployment calculations.

🧰 Tools
🪛 Biome (1.9.4)

[error] 150-150: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 150-150: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 150-155: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


165-170: Refinement in Specialist Allocation
The "extra_specialists" configuration now decrees "terminator": -5, "veteran": 55, "devastators": 10, and "assault": 10. Such numerical rites must be verified in simulation to ensure that the balance of martial prowess remains true to the Emperor’s vision.

🧰 Tools
🪛 Biome (1.9.4)

[error] 165-165: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 165-165: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 165-170: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


177-187: Marine Distribution Adjustment
The reallocation within "extra_marines"—notably, adjustments to the second, third, and fourth company allocations—imbues the chapter with a more measured strength. This reorganisation should be tested in the field to verify that the strategic equilibrium is preserved.

🧰 Tools
🪛 Biome (1.9.4)

[error] 177-177: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 177-177: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 177-187: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 187-187: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


207-212: Custom Roles Update for Apothecary
The apothecary has been reformed: now titled "Sanguinary Priest" with "wep1" set to "Power Axe". This update harmonises with the Blood Angels nomenclature and enriches the chapter’s lore. Ensure that downstream references honour this change in title and equipment.

🧰 Tools
🪛 Biome (1.9.4)

[error] 207-207: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 207-207: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 207-212: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

Copy link
Copy Markdown
Collaborator

@Blogaugis Blogaugis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏
I approve of these changes.

@OH296 OH296 merged commit 2757cbd into Adeptus-Dominus:main Mar 7, 2025
17 checks passed
@EttyKitty EttyKitty deleted the feat/lamenters-adj branch March 8, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants