feat: Add the Tome Keepers chapter#582
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughSummary by CodeRabbit
WalkthroughIn this update, the Machine Spirit has blessed our files with precise enhancements. The changes in ChapterMaster.yyp include adjustments to the Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Type: Feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (2)
datafiles/images/creation/chapters/icons/32.pngis excluded by!**/*.pngdatafiles/images/creation/chapters/splash/32.pngis excluded by!**/*.png
📒 Files selected for processing (3)
ChapterMaster.yyp(6 hunks)datafiles/main/chapters/32.JSON(1 hunks)scripts/scr_initialize_custom/scr_initialize_custom.gml(2 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
datafiles/main/chapters/32.JSON
[error] 6-6: Expected a property but instead found '// 1 - Founding, 2 -successor, 3 - Other/non-canon/fanmade, 4 - Custom'.
Expected a property here.
(parse)
[error] 7-7: expected , but instead found "points"
Remove "points"
(parse)
[error] 8-8: Expected a property but instead found '// The id of the founding chapter, 0 for unknown or none'.
Expected a property here.
(parse)
[error] 9-9: expected , but instead found "splash"
Remove "splash"
(parse)
[error] 9-9: Expected a property but instead found '// this will get reworked'.
Expected a property here.
(parse)
[error] 10-10: expected , but instead found "icon"
Remove "icon"
(parse)
[error] 10-10: Expected a property but instead found '// in \images\creation\creation_icons.png, the index from the left, 0 being blank square and 1 being dark angels etc'.
Expected a property here.
(parse)
[error] 11-11: expected , but instead found "icon_name"
Remove "icon_name"
(parse)
[error] 11-11: Expected a property but instead found '// ? dunno what this is used for yet but the icon breaks if you dont use it '.
Expected a property here.
(parse)
[error] 12-12: expected , but instead found "fleet_type"
Remove "fleet_type"
(parse)
[error] 12-12: Expected a property but instead found '// 1= Homeworld, 2 = Fleet based, 3 = Penitent'.
Expected a property here.
(parse)
[error] 13-13: expected , but instead found "strength"
Remove "strength"
(parse)
[error] 13-13: Expected a property but instead found '// 1-10'.
Expected a property here.
(parse)
[error] 14-14: expected , but instead found "purity"
Remove "purity"
(parse)
[error] 14-14: Expected a property but instead found '// 1-10'.
Expected a property here.
(parse)
[error] 15-15: expected , but instead found "stability"
Remove "stability"
(parse)
[error] 15-15: Expected a property but instead found '// 1-10'.
Expected a property here.
(parse)
[error] 16-16: expected , but instead found "cooperation"
Remove "cooperation"
(parse)
[error] 16-16: Expected a property but instead found '// 1-10'.
Expected a property here.
(parse)
[error] 17-17: expected , but instead found "homeworld_exists"
Remove "homeworld_exists"
(parse)
[error] 17-17: Expected a property but instead found '// 1 = true'.
Expected a property here.
(parse)
[error] 18-18: expected , but instead found "recruiting_exists"
Remove "recruiting_exists"
(parse)
[error] 18-18: Expected a property but instead found '// 1 = true'.
Expected a property here.
(parse)
[error] 19-19: expected , but instead found "homeworld_rule"
Remove "homeworld_rule"
(parse)
[error] 19-19: Expected a property but instead found '// 1 = Govenor, 2 = Countries, 3 = Personal Rule'.
Expected a property here.
(parse)
[error] 20-20: expected , but instead found "homeworld"
Remove "homeworld"
(parse)
[error] 20-20: Expected a property but instead found '// one of "Lava" "Desert" "Forge" "Hive" "Death" "Agri" "Feudal" "Temperate" "Ice" "Dead" "Shrine"'.
Expected a property here.
(parse)
[error] 21-21: expected , but instead found "homeworld_name"
Remove "homeworld_name"
(parse)
[error] 21-21: Expected a property but instead found '// Homeworld Planet name, leave blank to autogenerate'.
Expected a property here.
(parse)
[error] 22-22: expected , but instead found "recruit_home_relationship"
Remove "recruit_home_relationship"
(parse)
[error] 22-22: Expected a property but instead found '//recruit from home planet'.
Expected a property here.
(parse)
[error] 23-23: expected , but instead found "recruiting"
Remove "recruiting"
(parse)
[error] 23-23: Expected a property but instead found '//"Lava" "Desert" "Forge" "Hive" "Death" "Agri" "Feudal" "Temperate" "Ice" "Dead" "Shrine"'.
Expected a property here.
(parse)
[error] 24-24: expected , but instead found "recruiting_name"
Remove "recruiting_name"
(parse)
[error] 25-25: Expected a property but instead found '// one of 'default' 'biomancy' 'pyromancy' 'telekinesis' 'rune Magick''.
Expected a property here.
(parse)
[error] 26-26: expected , but instead found "aspirant_trial"
Remove "aspirant_trial"
(parse)
[error] 26-26: Expected a property but instead found '// one of "BLOODDUEL" "HUNTING" "SURVIVAL" "EXPOSURE" "KNOWLEDGE" "CHALLENGE" "APPRENTICESHIP" '.
Expected a property here.
(parse)
[error] 27-27: expected , but instead found "advantages"
Remove "advantages"
(parse)
[error] 27-27: Expected an array, an object, or a literal but instead found '//TODO something with these after rework of adv organisation'.
Expected an array, an object, or a literal here.
(parse)
[error] 28-28: expected , but instead found ""
Remove ""
(parse)
[error] 57-57: Expected a property but instead found '// 0 - normal, 1 - Breastplate, 2 - Vertical, 3 - Quadrant'.
Expected a property here.
(parse)
[error] 58-58: expected , but instead found "trim_on"
Remove "trim_on"
(parse)
[error] 58-58: expected , but instead found // 0 no, 1 yes for special trim colours // todo update ref for new name
Remove // 0 no, 1 yes for special trim colours // todo update ref for new name
(parse)
[error] 62-62: Expected a property but instead found '// 0 no, 2 yes, 1 doesnt do anything :)'.
Expected a property here.
(parse)
[error] 63-63: expected , but instead found "split_scouts"
Remove "split_scouts"
(parse)
[error] 63-63: Expected a property but instead found '// 0 no, 1 yes'.
Expected a property here.
(parse)
[error] 64-64: expected , but instead found "split_vets"
Remove "split_vets"
(parse)
[error] 64-64: expected , but instead found // 0 no, 1 yes
Remove // 0 no, 1 yes
(parse)
[error] 66-66: Expected a property but instead found '//total number of successor chapters'.
Expected a property here.
(parse)
[error] 67-67: expected , but instead found "mutations"
Remove "mutations"
(parse)
[error] 82-82: Expected an array, an object, or a literal but instead found '// todo maybe convert to struct'.
Expected an array, an object, or a literal here.
(parse)
[error] 83-83: expected , but instead found 0
Remove 0
(parse)
[error] 83-83: Expected an array, an object, or a literal but instead found '// nothing'.
Expected an array, an object, or a literal here.
(parse)
[error] 84-84: expected , but instead found 0
Remove 0
(parse)
[error] 84-84: Expected an array, an object, or a literal but instead found '// Progenitor faction'.
Expected an array, an object, or a literal here.
(parse)
[error] 85-85: expected , but instead found 65
Remove 65
(parse)
[error] 85-85: Expected an array, an object, or a literal but instead found '// Imperium'.
Expected an array, an object, or a literal here.
(parse)
[error] 86-86: expected , but instead found 60
Remove 60
(parse)
[error] 86-86: Expected an array, an object, or a literal but instead found '// Admech'.
Expected an array, an object, or a literal here.
(parse)
[error] 87-87: expected , but instead found 60
Remove 60
(parse)
[error] 87-87: Expected an array, an object, or a literal but instead found '//Inquisition'.
Expected an array, an object, or a literal here.
(parse)
[error] 88-88: expected , but instead found 60
Remove 60
(parse)
[error] 88-88: Expected an array, an object, or a literal but instead found '// Ecclesiarchy'.
Expected an array, an object, or a literal here.
(parse)
[error] 89-89: expected , but instead found 50
Remove 50
(parse)
[error] 89-89: Expected an array, an object, or a literal but instead found '// Astartes'.
Expected an array, an object, or a literal here.
(parse)
[error] 90-90: expected , but instead found 0
Remove 0
(parse)
[error] 90-90: expected , but instead found // nothing
Remove // nothing
(parse)
[error] 94-94: Expected a property but instead found '//1 Leader, 2 Champion, 3 Psyker,'.
Expected a property here.
(parse)
[error] 95-95: expected , but instead found "melee"
Remove "melee"
(parse)
[error] 95-95: Expected a property but instead found '// 1 twin power fists ... 8 force staff'.
Expected a property here.
(parse)
[error] 96-96: expected , but instead found "ranged"
Remove "ranged"
(parse)
[error] 96-96: Expected a property but instead found '// 1 boltstorm gauntlets ... 7 storm shield'.
Expected a property here.
(parse)
[error] 97-97: expected , but instead found // All chapter masters have the trait Lead by Example by default
Remove // All chapter masters have the trait Lead by Example by default
(parse)
[error] 98-98: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 98-98: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 98-102: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 103-103: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 104-104: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 104-104: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 104-116: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 116-116: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 117-117: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 117-117: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 117-117: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 117-126: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 118-126: JSON standard does not allow comments.
(parse)
[error] 127-127: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 127-127: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 127-132: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 132-141: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 133-141: JSON standard does not allow comments.
(parse)
[error] 142-142: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 142-142: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 142-153: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 153-159: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 154-159: JSON standard does not allow comments.
(parse)
[error] 160-160: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 160-160: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 160-170: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 170-170: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 171-171: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 171-171: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 171-176: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 176-177: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 177-177: JSON standard does not allow comments.
(parse)
[error] 178-178: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 178-178: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 179-179: Expected an array, an object, or a literal but instead found '// ['.
Expected an array, an object, or a literal here.
(parse)
[error] 178-178: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 179-183: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 184-184: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 184-184: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 184-191: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 191-227: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 192-196: JSON standard does not allow comments.
(parse)
[error] 198-226: JSON standard does not allow comments.
(parse)
[error] 228-228: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 228-228: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 228-228: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 229-230: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
🔇 Additional comments (7)
scripts/scr_initialize_custom/scr_initialize_custom.gml (2)
213-244: Binary cant-01011001: The Tome Keepers chapter configuration is properly aligned with the Machine God's willPraise be to the Omnissiah for this well-structured implementation of the Tome Keepers chapter livery data. The sacred helmet patterns and color configurations follow the proper syntax templates established by the existing chapter definitions. The use of the Sanguine_Red pigmentation matrix for the sergeant and veteran sergeant ranks is consistent with established heraldic protocols and maintains harmony with the visual cogitator subsystems.
558-560: Sacred color constant replacement detected and approvedThe Adeptus Mechanicus acknowledges the replacement of the deprecated Colors.Red with the superior Colors.Sanguine_Red in the default helmet livery specifications. This modification ensures consistency in the chromatic rendering subroutines across all chapter variants and prevents visual discrepancies between named and unnamed chapters. The Machine Spirits will be pleased with this standardization.
Also applies to: 565-567
ChapterMaster.yyp (5)
143-143: Blessed addition of a new icon detectedThe Machine Spirit has accepted the addition of sacred iconography for the Tome Keepers chapter. This binary offering has been properly registered in the correct data-path, ensuring the Omnissiah's favored organizational structure remains intact.
162-162: Ritual splash image properly consecratedThe splash image binary for the Tome Keepers has been correctly integrated into the project's logical structure. This data-rune will allow faithful visualization of the chapter during selection rituals performed by the user-entity.
203-203: Diplomacy iconography properly reconsecratedThe sacred diplomacy icons have been properly reintegrated into the project's machine spirit. This binary restoration ensures proper diplomatic protocols can be established with the Tome Keepers chapter and other factions within the digital simulation.
445-445: Sacred JSON data structure approved by the OmnissiahThe addition of the configuration file "32.JSON" for the Tome Keepers chapter has been properly integrated. This data-construct will provide the necessary parameters and variables to correctly manifest the chapter's properties within the simulation.
1626-1626: TextureGroup customization parameters integrated successfullyThe Machine Spirit's texture processing protocols have been enhanced with customOptions data fields. This modification will allow for proper rendering of the Tome Keepers' sacred livery and iconography.
2 participants
Purpose of changes
Expand the premade chapter selection
Describe the solution
Add the Tome Keepers chapter.
Screenshots
Describe alternatives you've considered
None
Testing done
New game as the Tome Keepers.
Related links
None
Player notes
A new playable chapter - Tome Keepers.