Skip to content

feat: 40k-ification of SRs/TLs#588

Merged
OH296 merged 6 commits intoAdeptus-Dominus:mainfrom
Blogaugis:feat-40k-ification-of-SRs-lite
Mar 15, 2025
Merged

feat: 40k-ification of SRs/TLs#588
OH296 merged 6 commits intoAdeptus-Dominus:mainfrom
Blogaugis:feat-40k-ification-of-SRs-lite

Conversation

@Blogaugis
Copy link
Copy Markdown
Collaborator

Purpose of changes

This small feature is part of community poll, should the #482 not be ready still, or simply rejected.

Describe the solution

Tweaking the Strength Ratings/Threat Levels to something sounding from 40k.

Describe alternatives you've considered

Tweak the #482 itself.

Testing done

  • Compilation,
  • Making to the game,
  • Checking the SR/TL on worlds,
  • End turn.

Related links

https://discord.com/channels/714022226810372107/1347837163714248756
#482

Custom player notes entry

Names of Strength Ratings/Threat Levels have been 40k-ified.

Tweaking the Strength Ratings/Threat levels to something sounding from 40k.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Refined in-game descriptive text for planetary conditions, offering a refreshed thematic presentation.
    • Updated threat level labels to ensure a more immersive and expressive gameplay experience.

Walkthrough

In this update, the code mappings for threat levels have been modified in two key areas of our system. Within the PlanetData constructor, the string values assigned to the variable now use new nomenclature ("Punicus", "Minorus", "Moderatus", "Significus", "Enormicus", "Extremis") instead of what was previously designated. Similarly, within the drop_select_draw function, the array that represents threat levels has been updated to mirror these new designations. The logical structures and flow remain unaltered, and there are no modifications to the declarations of exported or public entities. The changes ensure that threat level representations remain consistent throughout the codebase.

Possibly related PRs

Suggested labels

PR: Feature, PR: Balance, Size: Tiny

Suggested reviewers

  • OH296
  • KRdaMystic

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Type: Feature Adds something new Size: Tiny labels Mar 12, 2025
@Blogaugis
Copy link
Copy Markdown
Collaborator Author

@EttyKitty Up to You whether you choose to go ahead with 1st place poll results, or have something better.

@KRdaMystic
Copy link
Copy Markdown
Contributor

Please look into the Latin roots for some of these as that's where most of these can be traced linguistically extremus -> extremis

@Blogaugis
Copy link
Copy Markdown
Collaborator Author

Please look into the Latin roots for some of these as that's where most of these can be traced linguistically extremus -> extremis

Well, if you are confident about it, feel free to suggest changes.

Adds numbers showing the Strength Rating/Threat Level in addition to the name change.

@EttyKitty
@Blogaugis Blogaugis mentioned this pull request Mar 15, 2025
5 tasks
@OH296
Copy link
Copy Markdown
Collaborator

OH296 commented Mar 15, 2025

i mean i know minima tiny and parvus small for a start butt i've not studied in many years. Can someone tell me is this. a sticking point are we waiting for these terms to be upated? just trying to check status

@Blogaugis
Copy link
Copy Markdown
Collaborator Author

i mean i know minima tiny and parvus small for a start butt i've not studied in many years. Can someone tell me is this. a sticking point are we waiting for these terms to be upated? just trying to check status

Thanks.
I'll update it then. But I guess this is more a Latinization of the names rather than 40k-ization.
I'll rebase the branch, and add the 2 suggestions.

Tweaking the Strength Ratings/Threat levels to something sounding from 40k.
Adds numbers showing the Strength Rating/Threat Level in addition to the name change.

@EttyKitty
@Blogaugis Blogaugis force-pushed the feat-40k-ification-of-SRs-lite branch from 8fdbcde to 56d3f79 Compare March 15, 2025 11:37
@Blogaugis
Copy link
Copy Markdown
Collaborator Author

Though, the #482 should render these changes moot, as there would be much more of TLs/SRs.
This should be considered if we don't want to implement 482 for some reason, or want to purely add the Latinization.

@OH296
Copy link
Copy Markdown
Collaborator

OH296 commented Mar 15, 2025

Thanks. I'll update it then. But I guess this is more a Latinization of the names rather than 40k-ization. I'll rebase the branch, and add the 2 suggestions.

to be clear i'm not stating what you should do it was just off the top of my head things i could remember more than anything i'm just checking status. As is i do think some core latin mixed with the 40kish names is an improvement i think it's better for the blend and balance, any more than is currently i think would feel like a history lesson and more in the 40k direction is a bit cringe lol

@OH296 OH296 merged commit f879865 into Adeptus-Dominus:main Mar 15, 2025
3 checks passed
@Blogaugis Blogaugis deleted the feat-40k-ification-of-SRs-lite branch March 15, 2025 11:52
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: Tiny Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants