feat: Flesh Tearers

[VanWeapon]

Purpose

• New chapter

Describe your changes/additions

• Supposed to be even more black-ragey than Blood Angels, and have a standing Death Company. I couldn't figure out how death company/red thirst mechanics work and couldn't get it to trigger after several battles with Blood Angels so not sure what the best way to implement this would be

What can/needs to be improved/changed

• Black Rage/ Red Thirst mechanics are meh to non-existent at the moment. There is a lot that could be done mechanically here but i think it needs a bit of an overhaul that could either be done here or later in a different PR.
• Death Company marines as a unit trait rather than a role, it being a role is weird from a coding pov
• Only chaplains should be able to lead death company into battle. No chaplain present should prevent you from launching an assault orrr significantly penalise you with some kind of friendly fire mechanic or something.

Related things and/or additional context

• https://discord.com/channels/714022226810372107/1365140049661792326/1365140049661792326
• prior Death company discussions:
• https://discord.com/channels/714022226810372107/1253507748579250286
• https://discord.com/channels/714022226810372107/1216830507078389931

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Added the "Flesh Tearers" chapter, including detailed background, attributes, and custom units.
  • Introduced new chapter icon imagery for the "Flesh Tearers".

Walkthrough

By the Omnissiah’s decree, this update initiates the inclusion of two sacred data artefacts into the ChapterMaster project’s configuration. The first is a pict-capture file, “flesh_tearers.png”, sanctified for the chapter iconography. The second is a comprehensive JSON data scroll, “34.json”, encoding the full litany of the Flesh Tearers chapter: their gene-seed, livery, personnel, and chapter lore. No alterations to logic or exported machine-spirits are detected; the modifications are strictly in the domain of data and resource inclusion.

Changes

Files/Paths	Change Summary
ChapterMaster.yyp	Added references to the new image resource (“flesh_tearers.png”) and the new chapter data file (“34.json”) in the project configuration.
datafiles/main/chapters/34.json	Introduced a new JSON data file detailing the Flesh Tearers chapter: attributes, livery, personnel, lore, and all associated metadata.

Possibly related PRs

• feat: Add the Tome Keepers chapter #582: Adds the "Tome Keepers" chapter with its own JSON data and icon, modifying the same configuration files for resource inclusion as this PR, thus sharing a kindred purpose in the Machine God's grand design.

Suggested labels

PR: Feature, PR: Sprites, Size: Huge

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 8

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcf4e61 and c893f56.

⛔ Files ignored due to path filters (1)

• datafiles/images/creation/chapters/icons/flesh_tearers.png is excluded by !**/*.png

📒 Files selected for processing (2)

• ChapterMaster.yyp (2 hunks)
• datafiles/main/chapters/34.json (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

`**/*.json`: - JSON files with comments are supported by the parser used by this team. Don't warn or request changes to remove them.

**/*.json: - JSON files with comments are supported by the parser used by this team. Don't warn or request changes to remove them.

• datafiles/main/chapters/34.json

`**/*.*`: - Having humanly understandable and maintainable code is always the top most priority. - DRY (Don't repeat yourself) principle is also very important. - Ensure that the c...

**/*.*: - Having humanly understandable and maintainable code is always the top most priority.

• DRY (Don't repeat yourself) principle is also very important.
• Ensure that the code is compliant with the CODE_STYLE.MD: https://github.com/Adeptus-Dominus/ChapterMaster/blob/main/docs/CODE_STYLE.md

• datafiles/main/chapters/34.json
• ChapterMaster.yyp

🔇 Additional comments (4)

ChapterMaster.yyp (2)

139-139: Icon addition approved
The glyph flesh_tearers.png is correctly inserted in alphabetical order under datafiles/images/creation/chapters/icons.
Please verify that the file exists in the repository at the specified path and is referenced properly in the GMProject.

---

518-518: Chapter definition manifest approved
The sacred scroll 34.json is placed correctly following 33.json in datafiles/main/chapters.
Ensure the JSON conforms to the chapter schema and that the file is included in this PR.

datafiles/main/chapters/34.json (2)

3-17: Sanctify Mutation Rates Configuration
By the Omnissiah, the mutation block venerates Omophagea at full potency (1.0) and purges all others to 0.0, perfectly aligning with the Flesh Tearers’ dread gene-seed.

---

68-78:

Details

❌ Incorrect review comment

Guard Negative Marine Counts
Negative values for fifth and tenth companies (−100.0) may yield underflow or negative troop counts if not clamped. Ensure the engine handles these correctly.

Run this script to flag negative entries:

---

🏁 Script executed:

#!/bin/bash
jq '.chapter.extra_marines | to_entries[] | select(.value < 0)' datafiles/main/chapters/34.json

Length of output: 173

---

By the Omnissiah, I shall scour the code for all worshippers of extra_marines to see if the Machine-Spirit already clamps these negative offerings:

---

🏁 Script executed:

#!/bin/bash
rg -n "extra_marines" -C3

Length of output: 11593

---

Dismiss Negative Marine Clamping Concern
By the Omnissiah, the negative values in extra_marines are intentional subtractions, as documented in the chapter template (/* use negative numbers to subtract */). No underflow guard is required—these values correctly reduce company strengths.

Likely an incorrect or invalid review comment.