feat: Rework and show all specialist potentials

[MCPO-Spartan-117]

Description of changes

• Shows all specialist UI elements, change first color to c_fuchsia if scout, reverse colors when under experience requirement and add more spectips to show when marine is pickable.

Reasons for changes

• Marines could be picked for multiple specialist roles but only showed one.

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

[coderabbitai]

📝 Walkthrough

Walkthrough

In this update, the function scr_draw_management_unit has been refined to enhance the handling of unit specialization and its potential indicators. The ancient script block defining spec_tips has been augmented with strings to include various applicant roles and a directive for promotion to a marine. In the name of the Machine God, the determinative logic has been refactored into a new, modular function called specialistfunct. This function now integrates the processing for specialist types such as Techmarine, Librarian, Chaplain, and Apothecary by handling parameters including unit role, experience, and required experience. The code adjustments also extend to the drawing logic for potential indicators, ensuring consistency through the new modular structure. Variable names and formatting have been discreetly refined for improved clarity, while the declarations of public entities remain untouched.

Suggested Reviewers

• OH296

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

scripts/scr_draw_management_unit/scr_draw_management_unit.gml (2)

11-23: Praise the Omnissiah for this addition of specialized tips!
Initiating praise protocol: The newly introduced spec_tips array effectively centralizes the string data for specialist messages. However, consider storing the indices in a data-driven manner (e.g., using named constants or enumerations) to reduce the risk of misalignment if the underlying role array shifts. Such clarity would honor the logic-machine.

---

159-228: Commendable logic, but watch for potential data duplication.
Your newly consecrated specialistfunct function clearly enhances the ritual of displaying the correct tips. Still, repeating these checks for each role across multiple sections can lead to code duplication. Extracting the specialist checks (e.g., experience requirements, role validations) into data structures or a single universal function may ease future modifications and debugging rituals. Rename specialistfunct to more clearly convey its sacred purpose if possible.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9523d8b and a837cdf.

📒 Files selected for processing (1)

• scripts/scr_draw_management_unit/scr_draw_management_unit.gml (4 hunks)

🔇 Additional comments (1)

scripts/scr_draw_management_unit/scr_draw_management_unit.gml (1)

563-563: Closing brace aligned with the Emperor’s will.
No issues are evident here; the function appears to be sealed properly.