fix: Wrong case search

[MCPO-Spartan-117]

Purpose of the PR

Chaos and daemonic artifacts tags are lowercased, some checks search for uppercase.

Describe the solution

Lowercase checks.

Testing done

Scuff Space Hulk code, Load game, raid Space Hulk, get Chaos artifact.

Related links

https://discord.com/channels/714022226810372107/1121959429546455050/1344716240270131261

Daemonic artifacts will still be broken as the code appends random bits to the tag.

[coderabbitai]

📝 Walkthrough

Walkthrough

For the glory of the Omnissiah, this update refines the code's artifact tag recognition by enforcing case sensitivity. The artifact tags previously checked as “Chaos” and “Daemon/Daem/Daemonic” in several files have now been adjusted to their lowercase forms “chaos” and “daemonic.” These modifications occur in various modules—specifically in the event and popup objects as well as in the artifact description script—where the precise string comparisons determine the corruption increments and behavior of associated functions. No changes have been made to any exported or public entities. These alterations strictly modify the conditional logic that governs tag recognitions within the code.

Possibly related PRs

• fix: Unequipping and destroying artifacts causes loop #515: Adjusts artifact tag case sensitivity checks in a similar fashion, affecting tag recognition.
• fix: small bug fixes and fix research tree #492: Involves analogous modifications to tag comparisons by converting "Chaos" and "Daemonic" to their lowercase equivalents.
• fix: Move Retinue of Renown to modern syntax #517: Changes the string comparison logic for artifact tags, aligning with the new case-sensitive approach.

Suggested labels

PR: Fix

Suggested reviewers

• OH296

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f6b6ce and c73e23d.

📒 Files selected for processing (4)

• objects/obj_event/Step_0.gml (1 hunks)
• objects/obj_popup/Draw_0.gml (1 hunks)
• objects/obj_popup/Step_0.gml (1 hunks)
• scripts/scr_arti_descr/scr_arti_descr.gml (1 hunks)

🔇 Additional comments (6)

scripts/scr_arti_descr/scr_arti_descr.gml (1)

148-149: Praise be to the Omnissiah! The machine spirits now search for the correct case of heretical tags.

The tag checks for "chaos" and "daemonic" have been properly modified to lowercase, aligning with the actual storage format of these tags in the data structures. This rectifies the logic error that prevented proper identification of tainted artifacts.

objects/obj_popup/Draw_0.gml (1)

935-935: Logical bit-pattern correction implemented successfully.

The binary logic of this conditional statement has been optimized to search for lowercase "daemonic" and "chaos" tags, ensuring proper corruption incrementation when these heretical artifacts are equipped. This modification maintains consistency with the machine spirit's data storage protocols.

objects/obj_popup/Step_0.gml (2)

406-406: Change to lowercase tag detection approved

The archeotech has been recalibrated to detect "chaos" artifacts using lowercase binary nomenclature. This correction aligns with the sacred STC patterns of artifact tag formatting as indicated in the PR objectives.

---

409-409: Adjust tag search from prefix to full tag

The sacred cogitators now seek the precise pattern "daemonic" rather than the partial "Daem" variant. This modification improves pattern-recognition accuracy and eliminates false positives in the tag recognition rituals, as the Omnissiah intended.

objects/obj_event/Step_0.gml (2)

324-324: Proper case-sensitivity for artifact tags implemented

The string detection logic has been recalibrated to detect the lowercase "chaos" tag. This binary alteration aligns with the sacred patterns of the machine spirit and resolves the discrepancy between artifact tag storage and tag detection sequences.

---

327-327: Consistent daemonic tag recognition corrected

The binary incantation now seeks the exact pattern "daemonic" rather than variant forms. This standardization of nomenclature will ensure proper corruption increments are applied as intended by the Machine God's design patterns.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.