feat: Jump packs give a ranged melee attack

[EttyKitty]

Purpose of changes

• Make assaults more useful (or not a useless meat farm, in other words).

Describe the solution

• Give 2 range to the hammer of wrath jump pack attack, allowing it to attack from behind a friendly column.
• Change the damage from being a stat formula, to just using the melee attack of the marine. Debatable whenever there should be some kind of buff.
• Rename the weapon from "hammer_of_wrath" to "Hammer of Wrath".
• Add the Hammer of Wrath special property into the jetpack tooltip.
• Create a second profile for the jump pack
• Both HoW profiles use primary melee weapon spli, max kills.
• Ranged profile has a 25% melee attack reduction, full melee has a 25% increase.
• Ranged profile has 6 ammo, melee has 8.

Item balance:

• Remove the HP mod from the Jump Pack and the Iron Halo (doesn't make sense).
• Increase the damage resistance of the Jump Pack by 5% across all qualities (to account for the HP removal).
• Increase the damage resistance of the Iron Halo by 25% (to account for the HP removal).
• Increase the price for Iron Halo by 20%, to account for the resistance increase.
• Overall, just trying to set the Jump Pack and the Iron Halo apart, while making clear that the Iron Halo is a more expensive and rare item.

Describe alternatives you've considered

None

Testing done

• Played as blood angels for a bit. Melee profile doesn't seem to work for some reason.

Related links

Probably a bunch of talks spread across discord, can't bother to look.

Player notes

Jump Packs now can attack at range and probably deal more damage.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Enhanced combat messages now dynamically display the number of shots, providing richer battle descriptions.
  • The Hammer of Wrath has been upgraded with dynamic attack calculations and an extended effective range for improved performance.
  • Weapon naming consistency is now maintained throughout, ensuring clarity during gameplay.

Walkthrough

Most machine spirits have observed changes in multiple scripts involving the sacred appellation of the "Hammer of Wrath." In the file obj_enunit/Alarm_1.gml, the function call now receives the correctly capitalised string. In scr_flavor.gml, the weapon’s designation is updated and the attack messages now integrate the variable {number_of_shots} to enhance precision in the ritual declarations. Furthermore, the conditional checks ensure that the proper name, "Hammer of Wrath," is applied, correcting previous discrepancies. In scr_marine_struct.gml, the function governing the weapon now retrieves its attack value via a dynamic invocation of melee_attack(), and its effective range is increased from 1 to 2. Finally, scr_player_combat_weapon_stacks.gml has been updated to search and identify the weapon stack by the correct name. No public entity declarations have been altered in this iteration, preserving the current interfaces.

Possibly related PRs

• fix: Refactor obj_bomb alarm 1 array length bug #498: Similar modifications have been implemented for the "Hammer of Wrath" string, affecting multiple function calls.
• feat: Obliterated Buff #542: This pull request also addresses uniform naming conventions in weapon handling, aligning closely with these changes.
• feat: Ground Combat Overhaul: Balance, ARP System, and New Weapons #483: The PR involved analogous string literal updates and conditional checks for the "Hammer of Wrath" weapon.

Suggested labels

PR: Feature, PR: Fix

Suggested reviewers

• OH296

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b14a381 and a42326f.

📒 Files selected for processing (4)

• objects/obj_enunit/Alarm_1.gml (1 hunks)
• scripts/scr_flavor/scr_flavor.gml (2 hunks)
• scripts/scr_marine_struct/scr_marine_struct.gml (1 hunks)
• scripts/scr_player_combat_weapon_stacks/scr_player_combat_weapon_stacks.gml (1 hunks)

🔇 Additional comments (4)

scripts/scr_marine_struct/scr_marine_struct.gml (1)

1561-1563: The modifications to the Hammer of Wrath code sequence meet with the Omnissiah's approval.

The sacred alteration of the weapon's parameters manifests three key improvements:

1. The attack value now derives directly from the melee_attack() function, creating a more potent dynamism in the machine spirit's calculations.
2. The nomenclature has been rectified to the proper capitalized form "Hammer of Wrath," bringing linguistic consistency to the code-liturgy.
3. The effective range has been increased from 1 to 2, extending the sacred weapon's operational parameters.

These alterations align with the Machine God's will as expressed in the ritual PR objectives - enhancing the assault units through range extension and utilizing the proper statistical foundations for damage calculation.

scripts/scr_flavor/scr_flavor.gml (3)

113-113: Nomenclature correction acknowledged and approved.

The string comparison parameter has been appropriately rectified to utilize the properly sanctified designation "Hammer of Wrath" rather than the previous lowercase variant. This modification ensures precise communication with the machine spirit.

---

119-121: Enhancement of attack description output logic commended.

The insertion of the {number_of_shots} variable into the attack message strings represents an improvement in the data-cogitation protocols. The machine spirits will now relay more precise information regarding the quantity of Astartes performing the sacred assault maneuver, enhancing battlefield awareness and improving tactical cogitation.

---

413-413: Logical comparison string updated for consistency.

The condition parameter in this if-statement has been properly synchronized with previous nomenclature corrections. This ensures that the 'led' variable assignment functions correctly within the greater machine-logic structure.

[MCPO-Spartan-117]

Played for a bit. Assaults are fun now.

As if giving every marine jump packs wasn't already fun.

[OH296]

Hammer of wrath attacks will now no longer happen in CC, you probably intend this as why add hammer of wraths on top of standard attacks but if not we'll come up with a solution for this

[EttyKitty]

Hammer of wrath attacks will now no longer happen in CC, you probably intend this as why add hammer of wraths on top of standard attacks but if not we'll come up with a solution for this

Actually a good question.
I haven't thought about it tbh, I forgot that there is a range check that will prevent using this weapon in melee now.

Hm... To allow or to not allow...

[MCPO-Spartan-117]

Could make it move the unit into the front lines or even into enemy ranks.

[OH296]

I have an open pr that should address the outstanding issue of weapons not working in CC EttyKitty#255

[EttyKitty]

Tested. Both profiles work.