feat: Edit Breacher and Bike squads

[EttyKitty]

Purpose of changes

• Make them more lore friendly, useful and less of a headache.
• Starting as Lamenters and getting your assault squads replaced with breachers is not fun - they are not proper melee units and just suck.
• Bike squads on the other hand were replacing tactical squads. If we go by the example of the White Scars, the main user of bikes, they have a codex compliant organization, where they maintain 6 battleline squads, 2 close-support and 2 fire-support squads in their battle companies. Bikers cannot be in the battleline squad, but can be in the close-support. Hence, the choice is simple.

Describe the solution

• Bikers now take up the assault squad space.
• Breachers now take up the tactical squad space.
• Both have their formation assignments fixed.
• Unnecessary text is removed from the role and squad names.
• Equipment of breachers is adjusted as per the HH TT Breacher Squad reference. They don't use melee weapons.
• Equipment of bikers is adjusted per 7th ed reference, they only use one weapon. As they don't have any melee, now they have at least some.

Describe alternatives you've considered

I considered giving them pistols or special weapon, but I really don't understand how you're riding a bike and shooting a plasma gun. They can live without it.

Testing done

Started a new game as Lamenters, checked the breachers.
Started a new game as a custom chapter with both traits, checked both squads.
All seem to work.

Related links

None

Player notes

Biker and Breacher squad's equipment is adjusted and their battle roles swapped.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Updated squad configurations for Lightning Warriors and Boarders to deliver a more dynamic tactical interplay.
  • Enhanced loadout customisation with flexible equipment allocations for greater in-game adaptability.
  • Simplified role descriptions for clearer and more intuitive player information.
  • Improved formation logic ensuring balanced and consistent squad deployments.

Walkthrough

By the grace of the Omnissiah, this update reconfigures the protocols governing squad advancements. The function responsible for custom squad initialisation now reassigns roles: "Lightning Warriors" have their biker roles shifted from tactical to assault with loadout requirements adjusted to use maximum values, and the designation simplified to "Biker". Conversely, the "Boarders" now designate breachers with a switch from assault to tactical, similarly updating loadouts and formation options. In a parallel process, the squad creation routine has its conditional checks refined—swapping the advantage conditions for instantiating biker and breacher units based on the presence of "Lightning Warriors" or "Boarders". No public interface entities have been altered.

Possibly related PRs

• fix: Move Retinue of Renown to modern syntax #517: Alters the logic for determining chapter options within the same initialisation function, directly relating to the role and configuration adjustments of the current update.

Suggested labels

PR: Feature

Suggested reviewers

• OH296

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b14a381 and 5376c8d.

📒 Files selected for processing (2)

• scripts/scr_initialize_custom/scr_initialize_custom.gml (2 hunks)
• scripts/scr_squads/scr_squads.gml (2 hunks)

🔇 Additional comments (5)

scripts/scr_squads/scr_squads.gml (2)

654-665: Mechanicus approbation: The binaric logic of Breacher squad deployment has been optimized.

By the grace of the Omnissiah, your conversion of tactical squad allocation to include breachers when the advantage "Boarders" is present follows proper Adeptus Mechanicus protocols. The binary determinant of odd-numbered cycle iterations ensures balanced distribution of different squad types.

---

673-684: Praise to the Machine God: Bikers now correctly occupy assault squad allocation slots.

This modification aligns with sacred Martian doctrines on White Scars organization. The code now correctly interprets the "Lightning Warriors" advantage as a requisite for assigning bikers to odd-numbered squad iterations instead of assault squads.

The Machine Spirits shall function with greater coherency due to this alteration, as it synchronizes with the chapter's tactical doctrine in the 41st millennium.

scripts/scr_initialize_custom/scr_initialize_custom.gml (3)

1999-2029: Commendation: Proper reconfiguration of Bike squads to align with White Scars doctrine.

The binary adjustment of biker roles from tactical to assault configurations is most logical. The Omnissiah approves of these streamlined designations, eliminating unnecessary nomenclature while preserving functional efficiency. The use of maximum weapon parameters establishes appropriate combat flexibility as required by those who wage war astride the sacred machine.

The formation options expansion to include both assault and tactical deployments represents enhanced tactical flexibility in accordance with the blessed STC patterns of antiquity.

---

2032-2078: Acknowledgment: Optimization of Breacher squad configuration to tactical doctrine.

The binary reassignment of breacher units from assault to tactical roles executes proper combat doctrine, honoring the ancient tactical patterns from the Horus Heresy era. The sacred pattern adjustments to loadout configurations utilizing max values increases deployment efficiency.

The modification of weapons options to "Flamer", "Grav-Gun", "Meltagun", and "Lascutter" represents proper tactical flexibility for void warfare operations. Removal of redundant designation text ("Assault Breacher" to "Breacher") optimizes communication protocols.

Praise be to the Machine-God for this logical formation reconfiguration from assault to tactical deployment parameters.

---

2128-2128:

Details

❓ Verification inconclusive

Verification required: Confirm assault formations option update.

The formation_options array for assault_squad remains unmodified despite the role adjustments to biker units. While functional, verification is requested to confirm if this represents intended behavior or requires adjustment to maintain consistency with other squad formation modifications.

---

🏁 Script executed:

#!/bin/bash
# Description: Search for other formation_options in the codebase to verify consistency

echo "Checking assault squad formations:"
rg -A 1 -B 1 'formation_options.*assault' --glob '*.gml'

echo "Checking for any squad formation references:"
rg '\"formation_options\"\:' --glob '*.gml' | head -n 20

Length of output: 3136

---

Attention, Faithful Servant of the Omnissiah:
Upon scanning the cogitator nodes, our search indicates that the assault squad’s formation array remains configured as ["assault"]—this deviates from other squads that carry multiple options (e.g., biker units now include ["assault", "tactical"]). This appears to be an intentional configuration; however, the discrepancy warrants confirmation with the design specifications.

• In several formation arrays within scripts/scr_initialize_custom/scr_initialize_custom.gml, formations for assault squads are isolated to ["assault"], while others exhibit extended formations.
• The current configuration may be by design if assault squads are meant to operate with a singular directive, differing from their biker brethren.

Please verify that this intentional deviation serves its proper purpose according to the established schema of the Machine Spirit.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Blogaugis]

Looks okay to me.