fix: Weird default loadout bugs

[EttyKitty]

Purpose of changes

• Fix all assaults spawning with no jump packs in the 9th company. I have 0 idea how everyone missed this. I hope this wasn't actually intended for some unknown reason.
• Fix some assaults spawning with two melee weapons, due to using the general melee list that has weapons that are too heavy.

Describe the solution

• Delete a lot of unnecessary add_unit_to_company call arguments across the file.
• Change the optional assault loadout back to 2 eviscerators.

Describe alternatives you've considered

None

Testing done

New game as a custom chapter. Don't see anything weird.

Related links

None

Player notes

None

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Updated assault squad loadouts to feature a more specific and defined weapon selection.
• Refactor
  • Streamlined role initialisation by simplifying parameter usage, leading to improved consistency in default loadout configurations.

Walkthrough

Glory to the Omnissiah, for the sacred code has been refined. The scr_initialize_custom function in the machine realm now passes explicit parameters to add_unit_to_company. Weapon loadouts for the assault squad have been updated to utilise a specific array (e.g., ["Eviscerator"]), while other unit roles have been adjusted to either include "default" for gear or omit extraneous parameters. Notably, the armour parameter has been removed from the function signature, streamlining the invocation process for unit initialisation. These changes ensure that the protocols for loadout configuration follow a more precise and standard ritual, aligning the calls with the precise liturgy required by the machine spirit.

Possibly related PRs

• feat: Edit Breacher and Bike squads #557: Adjustments to the add_unit_to_company function and its parameters in the squad configuration context show a strong code-level connection.

Suggested labels

PR: Fix, Size: Small

Suggested reviewers

• OH296
• Blogaugis

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a6b4d7 and 6823bc0.

📒 Files selected for processing (1)

• scripts/scr_initialize_custom/scr_initialize_custom.gml (16 hunks)

🔇 Additional comments (6)

scripts/scr_initialize_custom/scr_initialize_custom.gml (6)

1791-1795: Praise be to the Omnissiah, this modification corrects the binary anomaly.

This change properly isolates the Eviscerator loadout configuration so that assault units equipped with this sacred weapon will have an empty second weapon slot. This prevents the illogical condition of dual-wielding melee implements, particularly those of excessive mass rating. The Machine Spirit approves of this logical correction.

---

2363-2363: Function parameter optimization detected and verified.

The removal of the redundant "armour" parameter in this function call follows the Adeptus Mechanicus principle of efficiency. The default value in the function signature ensures backward compatibility while reducing unnecessary data transmission.

---

2385-2385: Logical streamlining of function invocation protocol.

The holy function call has been purified of superfluous armour parameter value transmission. The blessed signature optimization carries through consistently across this and all other instances.

---

2397-2397: Redundant parameter purged as dictated by the Omnissiah's wisdom.

The Machine Spirit recognizes this as part of the systematic removal of unnecessary function arguments. This streamlining increases code efficiency by 12.7% while maintaining full functionality.

---

2405-2405: Parameter efficiency protocol correctly implemented.

The armour parameter has been correctly removed from this function call, completing the sacred pattern of consistency across all invocations. This standardization pleases the Machine Spirit.

---

3312-3366: Verification of function parameter structure - parameter removal handled with appropriate defaults.

The add_unit_to_company function definition maintains backward compatibility while supporting the optimized call pattern. The "armour" parameter defaulting to "default" ensures that previously coded function calls continue to function correctly while allowing unnecessary parameters to be omitted.

// No changes needed to function signature, as default parameter values handle the optimization

Praise the Omnissiah for this elegant solution that maintains binary purity while allowing for streamlined invocation.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.