Skip to content

fix: Remove old hover method for viewing marine stats#756

Merged
OH296 merged 1 commit intoAdeptus-Dominus:mainfrom
OH296:ui_manage_crash
Apr 21, 2025
Merged

fix: Remove old hover method for viewing marine stats#756
OH296 merged 1 commit intoAdeptus-Dominus:mainfrom
OH296:ui_manage_crash

Conversation

@OH296
Copy link
Copy Markdown
Collaborator

@OH296 OH296 commented Apr 21, 2025

Purpose

  • Self-descriptive. Used to be a way of viewing marine stats by hovering the marine image this is now redundant and was causing a crash

Describe your changes/additions

  • Self-descriptive.

What can/needs to be improved/changed

  • Nothing.

Testing done

  • None, and I understand the risks.

Related things and/or additional context

  • None.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 21, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Removed the automatic display of unit stats when hovering over certain UI regions or when the unit profile is active. Stats will no longer appear in these scenarios.

Walkthrough

By the Omnissiah's will, the sacred script within the scr_ui_manage function has been purged of logic responsible for displaying unit statistics upon the machine-spirits' detection of cursor incursion or activation of the unit_profile protocol. The cogitator's conditional code, which once checked for the presence of specific data-objects and toggled the stats_displayed state, has been excised. Now, only the rites pertaining to squad view rendering and profile toggling remain, unencumbered by the previous stat-display invocations.

Changes

Files Changed Change Summary
scripts/scr_ui_manage/scr_ui_manage.gml Removed conditional logic for displaying unit stats based on UI interaction; retained squad view and profile toggling code.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9876de6 and 97be17c.

📒 Files selected for processing (1)
  • scripts/scr_ui_manage/scr_ui_manage.gml (0 hunks)
💤 Files with no reviewable changes (1)
  • scripts/scr_ui_manage/scr_ui_manage.gml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Size: Tiny Type: Fix This is a fix for a bug labels Apr 21, 2025
@OH296 OH296 merged commit 671c9e4 into Adeptus-Dominus:main Apr 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: Tiny Type: Fix This is a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant