Add lc-task-mc to the workflow #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is this PR ready for review? |
Contributor
Author
|
Hi @vkucera . Yes, The PR is ready. I pushed also the updated "Compare.C" with the Lc plots in. |
ginnocen
approved these changes
Dec 20, 2020
Contributor
ginnocen
left a comment
ginnocen
left a comment
There was a problem hiding this comment.
hi @DelloStritto @nzardosh this is good to go from my side, as soon as the O2 PR is merged AliceO2Group/AliceO2#5013. Cheers GM
vkucera
requested changes
Dec 21, 2020
Collaborator
|
@ginnocen We need to decide here whether the Lc task should be included in the list of tasks activated by default, on top D0 and D+. |
vkucera
requested changes
Jan 13, 2021
Collaborator
There was a problem hiding this comment.
- Please update also the Run 5 JSON.
- Either Set
DOO2_TASK_LC=1or remove the condition inMakeScriptPostprocess. Otherwise theCompare.Cmacro is not executed by default. - These histograms do not have matching binnings. Please synchronise with Francesco.
-
hInvMassLc,hf-task-lc/hmass -
hDecLenLc,hf-task-lc/hdeclength
-
vkucera
requested changes
Jan 13, 2021
Collaborator
|
To merge after AliceO2Group/AliceO2#5150 |
Contributor
|
hi @DelloStritto @vkucera can we resolve these conflicts and check that everything works so that we can merge it? |
Contributor
Author
Contributor
|
@DelloStritto, no pb, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.