fix AwsDomainStoreTest test exception, aws.disableEc2Metadata true#3287
Merged
abvaidya merged 2 commits intoAthenZ:masterfrom Apr 8, 2026
Merged
fix AwsDomainStoreTest test exception, aws.disableEc2Metadata true#3287abvaidya merged 2 commits intoAthenZ:masterfrom
abvaidya merged 2 commits intoAthenZ:masterfrom
Conversation
Signed-off-by: Benjamin Huff <benjaminehuff@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Maven configuration to disable EC2 IMDS during tests to prevent real AWS calls and improves the error handling in AwsDomainStoreTest by using a finally block for property cleanup and broadening the expected exception types. I have provided feedback regarding the need for an explicit failure case when an exception is not thrown, the requirement to properly configure dummy properties for test coverage, and a correction for a log message inconsistency.
...ava/server_aws_common/src/test/java/io/athenz/syncer/aws/common/impl/AwsDomainStoreTest.java
Show resolved
Hide resolved
Signed-off-by: Benjamin Huff <benjaminehuff@gmail.com>
abvaidya
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
server_aws_commonmodule, we should not let the unit tests accessaws.disableEc2Metadataas it will cause tests to fail in unexpected and difficult to debug ways. Addresses issue raised here.Contribution Checklist: