Skip to content

fix AwsDomainStoreTest test exception, aws.disableEc2Metadata true #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abvaidya merged 2 commits into from
Apr 8, 2026
+24 −7
Merged

fix AwsDomainStoreTest test exception, aws.disableEc2Metadata true #3287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e76ea
fix AwsDomainStoreTest test exception, aws.disableEc2Metadata true
Bhuff1 Apr 8, 2026
877b633
comments addressed
Bhuff1 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions libs/java/server_aws_common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,21 @@
</dependencies>
</dependencyManagement>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<systemPropertyVariables>
<!-- Disable EC2 IMDS to prevent real AWS calls during tests -->
<aws.disableEc2Metadata>true</aws.disableEc2Metadata>
</systemPropertyVariables>
</configuration>
</plugin>
</plugins>
</build>

<dependencies>
<dependency>
<groupId>software.amazon.awssdk</groupId>
Expand Down
16 changes: 9 additions & 7 deletions .../server_aws_common/src/test/java/io/athenz/syncer/aws/common/impl/AwsDomainStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,17 @@ public void testAwsSyncerInitBadRegion() {

try {
new AwsDomainStore();
fail("Expected exception was not thrown");
} catch (Exception exc) {
System.out.println("testCloudInitBadRegion: AwsSyncer throws=" + exc);
assertTrue(exc instanceof SdkClientException);
System.out.println("testAwsSyncerInitBadRegion: AwsSyncer throws=" + exc);
assertTrue(exc instanceof SdkClientException || exc instanceof AwsServiceException,
"Expected SdkClientException or AwsServiceException, got: " + exc.getClass().getName());
Comment thread
Bhuff1 marked this conversation as resolved.
} finally {
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_ROOT_PATH);
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_AWS_ACCESS_KEY);
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_AWS_KEY_ID);
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_AWS_S3_REGION);
}

System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_ROOT_PATH);
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_AWS_ACCESS_KEY);
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_AWS_KEY_ID);
System.clearProperty(Config.PROP_PREFIX + Config.SYNC_CFG_PARAM_AWS_S3_REGION);
}

@Test
Expand Down
Loading