feat!: make unused msg disco fns private#20831
Merged
nventuro merged 4 commits intomerge-train/fairiesfrom Feb 27, 2026
Merged
Conversation
benesjan
reviewed
Feb 26, 2026
| @@ -36,7 +36,7 @@ pub unconstrained fn process_private_note_msg<Env>( | |||
|
|
|||
| /// Attempts discovery of a note given information about its contents and the transaction in which it is suspected the | |||
| /// note was created. | |||
| pub unconstrained fn attempt_note_discovery<Env>( | |||
| pub(crate) unconstrained fn attempt_note_discovery<Env>( | |||
Contributor
There was a problem hiding this comment.
I wanted to merge this PR but then after rebasing it did not compile. It turns out that this was broken to begin with because the token blacklist contract uses this function in the custom process_transparent_note method.
The transparent note flow is very archaic but it was kept around for demonstration purposes so I think it would be fine to just get rid of that.
But anyway makes sense to revert this smol change here and handle that in a followup if deemed desirable.
Did the revert of this change in eab8bd2
benesjan
force-pushed
the
nico/f-358-make-msg-discovery-functions-private
branch
from
cf394d6 to
eab8bd2
Compare
Contributor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
approved these changes
Feb 26, 2026
| /// This is `None` if the nullifier cannot be computed (e.g., because the nullifier hiding key is not available). | ||
| /// The result of [`crate::note::note_interface::NoteHash::compute_nullifier_unconstrained`]. | ||
| /// | ||
| /// This value is unconstrained as all of message discovery is unconstrained. This is `None` if the nullifier |
Contributor
There was a problem hiding this comment.
This change made the code un-compilable because the fields are directly used by generate_contract_library_method_compute_note_hash_and_nullifier.
Reverted this change as it makes sense to tackle in a followup.
| /// The result of [`crate::note::note_interface::NoteHash::compute_nullifier_unconstrained`]. | ||
| /// | ||
| /// This value is unconstrained, as all of message discovery is unconstrained. It is `None` if the nullifier | ||
| /// cannot be computed (e.g. because the nullifier hiding key is not available). |
Contributor
There was a problem hiding this comment.
I found it slightly confusing here that we mention that only this value is unconstrained even though whenever we use the NoteHashAndNullifier type even the note_hash is unconstrained.
I get what you mean though
…-functions-private
Collaborator
|
❌ Failed to cherry-pick to |
Collaborator
|
❌ Failed to cherry-pick to |
johnathan79717
pushed a commit
that referenced
this pull request
Mar 4, 2026
I adjusted some docs of public functions and made some that were `pub` into `pub(crate)`, since users should not need to use them. --------- Co-authored-by: benesjan <janbenes1234@gmail.com>
AztecBot
added a commit
that referenced
this pull request
Mar 18, 2026
AztecBot
added a commit
that referenced
this pull request
Mar 18, 2026
nventuro
added a commit
that referenced
this pull request
Mar 19, 2026
…1134, #21072, #21186, #21189, #21229, #21228, #21234, #21639) (#21745) ## Summary Combined backport of 12 PRs to v4-next, cherry-picked in chronological merge order: 1. #20512 — docs: add delayedpublicmutable apiref, fix misc docs 2. #20379 — feat: custom message handlers in Aztec.nr 3. #20831 — feat!: make unused msg disco fns private 4. #21024 — feat: add compile-time size check for events and error code links 5. #21134 — chore: add warning on invalid recipients 6. #21072 — feat: add aztecaddress::is_valid 7. #21186 — chore: use returns `true` for boolean fns 8. #21189 — feat: add note hash and nullifier helper functions with domain separation 9. #21229 — docs: small delayedpubmut update 10. #21228 — test: restore pubmut tests 11. #21234 — fix: claim contract & improve nullif docs 12. #21639 — feat!: split compute note hash and nullifier to reduce hashing Each PR is a separate commit (raw cherry-pick with conflicts left in), followed by a single final commit that resolves all conflicts — making it easy to review the conflict resolution independently. ## Conflict resolution (last commit) - `delayed_public_mutable.nr` / `public_immutable.nr` — merged doc comments from both sides - `aztec.nr` macros — integrated custom message handler + split compute functions - `discovery/mod.nr` / `process_message.nr` — merged offchain inbox sync + custom handler dispatch + split compute - `constants.nr` / `constants_tests.nr` — added new domain separators - `Nargo.toml` — added custom_message_contract - `netlify.toml` — merged error code redirects - `auth_contract` — kept v4-next delay value - `note_metadata.nr` — doc comment reformat - `migration_notes.md` — merged migration notes from both sides - Deleted `traits.nr` (v4-next uses `traits/` directory) ClaudeBox log: https://claudebox.work/s/3145d1bd30977c20?run=1 --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adjusted some docs of public functions and made some that were
pubintopub(crate), since users should not need to use them.